Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/modules/vr/VRDisplayEventInit.idl

Issue 2342393002: Enable TypeError for dictionary members of non-nullable interface type (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/speech/SpeechRecognitionEventInit.idl ('k') | third_party/WebKit/Source/modules/webmidi/MIDIConnectionEventInit.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/vr/VRDisplayEventInit.idl
diff --git a/third_party/WebKit/Source/modules/vr/VRDisplayEventInit.idl b/third_party/WebKit/Source/modules/vr/VRDisplayEventInit.idl
index b223f2c7dc6425ec6e0cc85bdcb2be1510f84952..b07bab6567c3bed477be5623a9278533041240b3 100644
--- a/third_party/WebKit/Source/modules/vr/VRDisplayEventInit.idl
+++ b/third_party/WebKit/Source/modules/vr/VRDisplayEventInit.idl
@@ -6,6 +6,9 @@
[
RuntimeEnabled=WebVR
] dictionary VRDisplayEventInit : EventInit {
- VRDisplay display;
+ // TODO(foolip): |display| should be required and not nullable.
+ // https://crbug.com/647693
+ // https://github.com/w3c/webvr/issues/83
+ VRDisplay? display;
VRDisplayEventReason reason;
};
« no previous file with comments | « third_party/WebKit/Source/modules/speech/SpeechRecognitionEventInit.idl ('k') | third_party/WebKit/Source/modules/webmidi/MIDIConnectionEventInit.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698