third_party/WebKit/Source/core/events/MessageEventInit.idl - Issue 2342393002: Enable TypeError for dictionary members of non-nullable interface type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/MessageEventInit.idl

Issue 2342393002: Enable TypeError for dictionary members of non-nullable interface type (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/events/MessageEventInit.idl

diff --git a/third_party/WebKit/Source/core/events/MessageEventInit.idl b/third_party/WebKit/Source/core/events/MessageEventInit.idl

index d25296560e227796bf7456995fcd93ad5e6f11ed..6b4fbd664db2a897cc23dc4cf4af99e05a1efe58 100644

--- a/third_party/WebKit/Source/core/events/MessageEventInit.idl

+++ b/third_party/WebKit/Source/core/events/MessageEventInit.idl

@@ -9,7 +9,7 @@ dictionary MessageEventInit : EventInit {

DOMString origin;

DOMString lastEventId;

// TODO(bashi): |source| should be (WindowProxy or MessagePort)?

- EventTarget source;

+ EventTarget? source;

// Per spec, |ports| isn't nullable, but it seems it should be.

// https://www.w3.org/Bugs/Public/show_bug.cgi?id=23176

sequence<MessagePort>? ports;