third_party/WebKit/Source/core/events/MessageEventInit.idl - Issue 2342393002: Enable TypeError for dictionary members of non-nullable interface type

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/events/MessageEventInit.idl

Issue 2342393002: Enable TypeError for dictionary members of non-nullable interface type (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://html.spec.whatwg.org/multipage/comms.html#the-messageevent-interfaces	5 // https://html.spec.whatwg.org/multipage/comms.html#the-messageevent-interfaces

6	6

7 dictionary MessageEventInit : EventInit {	7 dictionary MessageEventInit : EventInit {

8 any data;	8 any data;

9 DOMString origin;	9 DOMString origin;

10 DOMString lastEventId;	10 DOMString lastEventId;

11 // TODO(bashi): \|source\| should be (WindowProxy or MessagePort)?	11 // TODO(bashi): \|source\| should be (WindowProxy or MessagePort)?

12 EventTarget source;	12 EventTarget? source;

13 // Per spec, \|ports\| isn't nullable, but it seems it should be.	13 // Per spec, \|ports\| isn't nullable, but it seems it should be.

14 // https://www.w3.org/Bugs/Public/show_bug.cgi?id=23176	14 // https://www.w3.org/Bugs/Public/show_bug.cgi?id=23176

15 sequence<MessagePort>? ports;	15 sequence<MessagePort>? ports;

16 };	16 };

OLD	NEW