Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2342353002: Clean up includes in SVGFE*Element and thereabouts (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up includes in SVGFE*Element and thereabouts Drop inclusion of SVGParserUtilities.h in a number of places since it's no longer used. Push FE*.h inclusion into the implementation where possible, and don't include FilterEffect.h in those cases. Also simplify a loop in SVGFEMergeElement::build. Committed: https://crrev.com/07ca63d57084d2d1363327ad537bff55098e7108 Cr-Commit-Position: refs/heads/master@{#419187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -31 lines) Patch
M third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEColorMatrixElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEComponentTransferElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEComponentTransferElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEFloodElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEFloodElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEGaussianBlurElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEGaussianBlurElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMergeElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMergeElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMorphologyElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEOffsetElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEOffsetElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFETileElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFETileElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFETurbulenceElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
fs
4 years, 3 months ago (2016-09-16 14:02:18 UTC) #4
Stephen Chennney
lgtm
4 years, 3 months ago (2016-09-16 16:31:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342353002/1
4 years, 3 months ago (2016-09-16 16:35:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 16:41:25 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 16:43:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07ca63d57084d2d1363327ad537bff55098e7108
Cr-Commit-Position: refs/heads/master@{#419187}

Powered by Google App Engine
This is Rietveld 408576698