Refine FontLoadHistograms::recordRemoteFont() logic

Refine FontLoadHistograms::recordRemoteFont() logic

1. Move cacheHitHistogram count out of if statement to include memory cache
hits, whose |m_loadStartTime| is 0.
2. Remove redundant checks in if statement. After previous refactoring,
recordRemoteFont() is now only called once from notifyFinished(), and |font|
here is always available and loaded.
3. Use DataSource to determine cases to record load time (data URL loads have
non-zero |m_loadStartTime| but should complete immediately).

Committed: https://crrev.com/e07469c81053c55c60a64a8ea55e919f7524b619
Cr-Commit-Position: refs/heads/master@{#419144}

[Shao-Chuan Lee, 2016-09-16 08:22:33]

shaochuan@chromium.org changed reviewers:
+ ksakamoto@chromium.org

[Shao-Chuan Lee, 2016-09-16 08:22:34]

PTAL

recordRemoteFont() used to be called from FontResourceClient::fontLoaded(),
which was removed in https://codereview.chromium.org/1894953002.

[Kunihiko Sakamoto, 2016-09-16 09:03:15]

https://codereview.chromium.org/2342273003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp (right):

https://codereview.chromium.org/2342273003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp:274: m_loadStartTime
= -1;
We can remove this line, as this function is called only once now.

[Shao-Chuan Lee, 2016-09-16 09:23:17]

https://codereview.chromium.org/2342273003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp (right):

https://codereview.chromium.org/2342273003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp:274: m_loadStartTime
= -1;
On 2016/09/16 09:03:15, Kunihiko Sakamoto wrote:
> We can remove this line, as this function is called only once now.

Done.

[Kunihiko Sakamoto, 2016-09-16 09:24:54]

lgtm

[Shao-Chuan Lee, 2016-09-16 09:27:12]

shaochuan@chromium.org changed reviewers:
+ haraken@chromium.org

[Shao-Chuan Lee, 2016-09-16 09:27:13]

haraken@chromium.org: PTAL

[haraken, 2016-09-16 09:55:31]

LGTM

[Shao-Chuan Lee, 2016-09-16 10:25:53]

The CQ bit was checked by shaochuan@chromium.org

[commit-bot: I haz the power, 2016-09-16 10:26:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 11:30:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-16 11:33:01]

Description was changed from

==========
Refine FontLoadHistograms::recordRemoteFont() logic

1. Move cacheHitHistogram count out of if statement to include memory cache
hits, whose |m_loadStartTime| is 0.
2. Remove redundant checks in if statement. After previous refactoring,
recordRemoteFont() is now only called once from notifyFinished(), and |font|
here is always available and loaded.
3. Use DataSource to determine cases to record load time (data URL loads have
non-zero |m_loadStartTime| but should complete immediately).
==========

to

==========
Refine FontLoadHistograms::recordRemoteFont() logic

1. Move cacheHitHistogram count out of if statement to include memory cache
hits, whose |m_loadStartTime| is 0.
2. Remove redundant checks in if statement. After previous refactoring,
recordRemoteFont() is now only called once from notifyFinished(), and |font|
here is always available and loaded.
3. Use DataSource to determine cases to record load time (data URL loads have
non-zero |m_loadStartTime| but should complete immediately).

Committed: https://crrev.com/e07469c81053c55c60a64a8ea55e919f7524b619
Cr-Commit-Position: refs/heads/master@{#419144}
==========

[commit-bot: I haz the power, 2016-09-16 11:33:02]

Patchset 2 (id:??) landed as
https://crrev.com/e07469c81053c55c60a64a8ea55e919f7524b619
Cr-Commit-Position: refs/heads/master@{#419144}