Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1894953002: WebFonts: merge fontLoaded() to notifyFinished() (Closed)

Created:
4 years, 8 months ago by Takashi Toyoshima
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-css, loading-reviews_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, darktears, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebFonts: merge fontLoaded() to notifyFinished() Remove a FontResourceClient specific callback fontLoaded() and use ResourceClient::notifyFinished() instead. BUG=n/a Committed: https://crrev.com/2d8b210dffbc41e44addc6a6c16a507d5de171a0 Cr-Commit-Position: refs/heads/master@{#388165}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review #6 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/FontResource.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/FontResource.cpp View 1 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894953002/1
4 years, 8 months ago (2016-04-18 07:47:17 UTC) #2
Takashi Toyoshima
let me split this trivial changes from https://codereview.chromium.org/1893233002/ because I need another investigation to find ...
4 years, 8 months ago (2016-04-18 08:07:09 UTC) #5
Kunihiko Sakamoto
https://codereview.chromium.org/1894953002/diff/1/third_party/WebKit/Source/core/fetch/FontResource.cpp File third_party/WebKit/Source/core/fetch/FontResource.cpp (right): https://codereview.chromium.org/1894953002/diff/1/third_party/WebKit/Source/core/fetch/FontResource.cpp#newcode101 third_party/WebKit/Source/core/fetch/FontResource.cpp:101: c->notifyFinished(this); This is called by above Resource::didAddClient(), isn't it?
4 years, 8 months ago (2016-04-18 08:18:59 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/212712)
4 years, 8 months ago (2016-04-18 09:08:51 UTC) #8
Takashi Toyoshima
https://codereview.chromium.org/1894953002/diff/1/third_party/WebKit/Source/core/fetch/FontResource.cpp File third_party/WebKit/Source/core/fetch/FontResource.cpp (right): https://codereview.chromium.org/1894953002/diff/1/third_party/WebKit/Source/core/fetch/FontResource.cpp#newcode101 third_party/WebKit/Source/core/fetch/FontResource.cpp:101: c->notifyFinished(this); On 2016/04/18 08:18:59, Kunihiko Sakamoto wrote: > This ...
4 years, 8 months ago (2016-04-18 12:42:03 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894953002/20001
4 years, 8 months ago (2016-04-18 12:42:35 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 13:47:27 UTC) #13
Kunihiko Sakamoto
lgtm
4 years, 8 months ago (2016-04-19 01:11:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894953002/20001
4 years, 8 months ago (2016-04-19 05:05:16 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/170181)
4 years, 8 months ago (2016-04-19 05:12:34 UTC) #18
Takashi Toyoshima
kinuko@chromium.org: this change was reviewed by ksakamoto@, but could you take another look for submitting?
4 years, 8 months ago (2016-04-19 06:30:12 UTC) #20
kinuko
lgtm
4 years, 8 months ago (2016-04-19 07:51:14 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894953002/20001
4 years, 8 months ago (2016-04-19 08:05:59 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 08:10:18 UTC) #25
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 08:11:08 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d8b210dffbc41e44addc6a6c16a507d5de171a0
Cr-Commit-Position: refs/heads/master@{#388165}

Powered by Google App Engine
This is Rietveld 408576698