Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2342233002: Remove Fetch[Blob|FormData]ConsumerHandle (Closed)

Created:
4 years, 3 months ago by yhirano
Modified:
4 years, 2 months ago
Reviewers:
hiroshige, haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Fetch[Blob|FormData]ConsumerHandle They are replaced with [Blob|FormData]BytesConsumer. BUG=610195 Committed: https://crrev.com/8f2a8e1eaba8b30b7ce4e3ba7b7fde81a42bc765 Cr-Commit-Position: refs/heads/master@{#421440}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2677 lines) Patch
M third_party/WebKit/Source/modules/BUILD.gn View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 4 chunks +4 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumer.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumerForDataConsumerHandle.h View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp View 1 chunk +0 lines, -219 lines 0 comments Download
D third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandleTest.cpp View 1 chunk +0 lines, -493 lines 0 comments Download
D third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h View 1 chunk +0 lines, -177 lines 0 comments Download
D third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.h View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp View 1 chunk +0 lines, -319 lines 0 comments Download
D third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp View 1 chunk +0 lines, -449 lines 0 comments Download
D third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.h View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp View 1 chunk +0 lines, -338 lines 0 comments Download
D third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp View 1 chunk +0 lines, -445 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Request.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/RequestInit.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/RequestInit.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 4 chunks +9 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 33 (25 generated)
yhirano
4 years, 3 months ago (2016-09-21 05:26:01 UTC) #19
yhirano
On 2016/09/21 05:26:01, yhirano wrote: ping
4 years, 2 months ago (2016-09-27 05:42:48 UTC) #22
hiroshige
lgtm if bots are happy.
4 years, 2 months ago (2016-09-27 07:33:09 UTC) #23
yhirano
+haraken@ for modules/BUILD.gn.
4 years, 2 months ago (2016-09-27 07:56:20 UTC) #26
haraken
LGTM
4 years, 2 months ago (2016-09-27 08:37:38 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342233002/80001
4 years, 2 months ago (2016-09-28 02:19:17 UTC) #29
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 2 months ago (2016-09-28 03:51:55 UTC) #31
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 03:56:06 UTC) #33
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f2a8e1eaba8b30b7ce4e3ba7b7fde81a42bc765
Cr-Commit-Position: refs/heads/master@{#421440}

Powered by Google App Engine
This is Rietveld 408576698