Remove FetchFormDataConsumerHandle use in SRIVerifier

Remove FetchFormDataConsumerHandle use in SRIVerifier

BUG=610195
Committed: https://crrev.com/1396f15cd63edb897183140ad124770dfc2b889e
Cr-Commit-Position: refs/heads/master@{#421426}

[yhirano, 2016-09-16 01:28:23]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 01:28:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-16 01:32:04]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 01:32:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 01:38:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 01:38:12]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[yhirano, 2016-09-16 01:53:05]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 01:53:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-16 01:57:17]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 01:57:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 02:22:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 02:22:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhirano, 2016-09-16 02:57:57]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 02:58:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-16 03:10:48]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 03:11:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-16 05:03:05]

Patchset #5 (id:80001) has been deleted

[yhirano, 2016-09-16 05:03:10]

Patchset #4 (id:60001) has been deleted

[yhirano, 2016-09-16 05:03:17]

Patchset #3 (id:40001) has been deleted

[yhirano, 2016-09-16 05:03:25]

Patchset #2 (id:20001) has been deleted

[yhirano, 2016-09-16 05:04:03]

yhirano@chromium.org changed reviewers:
+ hiroshige@chromium.org

[yhirano, 2016-09-16 05:04:25]

Description was changed from

==========
Replace FetchFormDataConsumerHandle use in SRIVerifier

BUG=610195
==========

to

==========
Remove FetchFormDataConsumerHandle use in SRIVerifier

BUG=610195
==========

[commit-bot: I haz the power, 2016-09-16 05:27:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 05:27:24]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-09-21 03:37:27]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 03:37:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-21 04:09:02]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 04:09:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 05:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 05:34:45]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-09-27 05:42:40]

On 2016/09/16 05:04:04, yhirano wrote:

ping

[hiroshige, 2016-09-27 07:45:44]

Basically looks good.

https://codereview.chromium.org/2344103002/diff/130001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/FetchManager.cpp (right):

https://codereview.chromium.org/2344103002/diff/130001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchManager.cpp:55: class
SRIBytesConsumer : public BytesConsumer {
final

https://codereview.chromium.org/2344103002/diff/130001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchManager.cpp:82: DCHECK(client);
DCHECK(!m_client);

https://codereview.chromium.org/2344103002/diff/130001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchManager.cpp:86: m_client = nullptr;
|m_client = client|?

https://codereview.chromium.org/2344103002/diff/130001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchManager.cpp:100: m_isCancelled =
true;
Do we need to clear |m_client| here?

https://codereview.chromium.org/2344103002/diff/130001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchManager.cpp:227:
m_updater->update(new
BytesConsumerForDataConsumerHandle(m_response->getExecutionContext(),
createFetchDataConsumerHandleFromWebHandle(createUnexpectedErrorDataConsumerHandle())));
Do you plan to create BytesConsumer-version of
createUnexpectedErrorDataConsumerHandle() and replace this line in the future?

[yhirano, 2016-09-27 07:51:25]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 07:51:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-27 07:53:58]

https://codereview.chromium.org/2344103002/diff/130001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/FetchManager.cpp (right):

https://codereview.chromium.org/2344103002/diff/130001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchManager.cpp:55: class
SRIBytesConsumer : public BytesConsumer {
On 2016/09/27 07:45:43, hiroshige wrote:
> final

Done.

https://codereview.chromium.org/2344103002/diff/130001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchManager.cpp:82: DCHECK(client);
On 2016/09/27 07:45:43, hiroshige wrote:
> DCHECK(!m_client);

Done.

https://codereview.chromium.org/2344103002/diff/130001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchManager.cpp:86: m_client = nullptr;
On 2016/09/27 07:45:43, hiroshige wrote:
> |m_client = client|?

You're right, thank you. Done.

https://codereview.chromium.org/2344103002/diff/130001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchManager.cpp:100: m_isCancelled =
true;
On 2016/09/27 07:45:43, hiroshige wrote:
> Do we need to clear |m_client| here?

Nice catch. Done.

https://codereview.chromium.org/2344103002/diff/130001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchManager.cpp:227:
m_updater->update(new
BytesConsumerForDataConsumerHandle(m_response->getExecutionContext(),
createFetchDataConsumerHandleFromWebHandle(createUnexpectedErrorDataConsumerHandle())));
On 2016/09/27 07:45:43, hiroshige wrote:
> Do you plan to create BytesConsumer-version of
> createUnexpectedErrorDataConsumerHandle() and replace this line in the future?

Yes, I will do that.

[hiroshige, 2016-09-27 08:03:06]

lgtm.

[commit-bot: I haz the power, 2016-09-27 09:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 09:13:27]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-09-28 02:00:56]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-09-28 02:01:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 02:06:15]

Description was changed from

==========
Remove FetchFormDataConsumerHandle use in SRIVerifier

BUG=610195
==========

to

==========
Remove FetchFormDataConsumerHandle use in SRIVerifier

BUG=610195
==========

[commit-bot: I haz the power, 2016-09-28 02:06:17]

Committed patchset #5 (id:150001)

[commit-bot: I haz the power, 2016-09-28 02:07:50]

Description was changed from

==========
Remove FetchFormDataConsumerHandle use in SRIVerifier

BUG=610195
==========

to

==========
Remove FetchFormDataConsumerHandle use in SRIVerifier

BUG=610195

Committed: https://crrev.com/1396f15cd63edb897183140ad124770dfc2b889e
Cr-Commit-Position: refs/heads/master@{#421426}
==========

[commit-bot: I haz the power, 2016-09-28 02:07:51]

Patchset 5 (id:??) landed as
https://crrev.com/1396f15cd63edb897183140ad124770dfc2b889e
Cr-Commit-Position: refs/heads/master@{#421426}