Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.h

Issue 2342103002: Refactor the way PaintArtifactCompositor is attached and used. (Closed)
Patch Set: none Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/ChromeClient.h
diff --git a/third_party/WebKit/Source/core/page/ChromeClient.h b/third_party/WebKit/Source/core/page/ChromeClient.h
index 5bfb05099c3cf45ff2ceb199b998a88a83ca12c1..a2ae089b4b03b7cf62c8091b67c6289a33fcd00e 100644
--- a/third_party/WebKit/Source/core/page/ChromeClient.h
+++ b/third_party/WebKit/Source/core/page/ChromeClient.h
@@ -70,6 +70,7 @@ class PopupOpeningObserver;
class WebDragData;
class WebFrameScheduler;
class WebImage;
+class WebLayer;
struct CompositedSelection;
struct DateTimeChooserParameters;
@@ -196,14 +197,15 @@ public:
// Asychronous request to enumerate all files in a directory chosen by the user.
virtual void enumerateChosenDirectory(FileChooser*) = 0;
- // Pass 0 as the GraphicsLayer to detach the root layer.
+ // Pass nullptr as the GraphicsLayer to detach the root layer.
// This sets the graphics layer for the LocalFrame's WebWidget, if it has
// one. Otherwise it sets it for the WebViewImpl.
virtual void attachRootGraphicsLayer(GraphicsLayer*, LocalFrame* localRoot) = 0;
- // In Slimming Paint v2, called when the paint artifact is updated, to allow
- // the underlying web widget to composite it.
- virtual void didPaint(const PaintArtifact&) { }
+ // Pass nullptr as the WebLayer to detach the root layer.
+ // This sets the WebLayer for the LocalFrame's WebWidget, if it has
+ // one. Otherwise it sets it for the WebViewImpl.
+ virtual void attachRootLayer(WebLayer*, LocalFrame* localRoot) = 0;
virtual void attachCompositorAnimationTimeline(CompositorAnimationTimeline*, LocalFrame* localRoot) { }
virtual void detachCompositorAnimationTimeline(CompositorAnimationTimeline*, LocalFrame* localRoot) { }

Powered by Google App Engine
This is Rietveld 408576698