Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: third_party/WebKit/Source/core/page/ChromeClient.h

Issue 2342103002: Refactor the way PaintArtifactCompositor is attached and used. (Closed)
Patch Set: none Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 4 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 class HitTestResult; 63 class HitTestResult;
64 class IntRect; 64 class IntRect;
65 class LocalFrame; 65 class LocalFrame;
66 class Node; 66 class Node;
67 class Page; 67 class Page;
68 class PaintArtifact; 68 class PaintArtifact;
69 class PopupOpeningObserver; 69 class PopupOpeningObserver;
70 class WebDragData; 70 class WebDragData;
71 class WebFrameScheduler; 71 class WebFrameScheduler;
72 class WebImage; 72 class WebImage;
73 class WebLayer;
73 74
74 struct CompositedSelection; 75 struct CompositedSelection;
75 struct DateTimeChooserParameters; 76 struct DateTimeChooserParameters;
76 struct FrameLoadRequest; 77 struct FrameLoadRequest;
77 struct GraphicsDeviceAdapter; 78 struct GraphicsDeviceAdapter;
78 struct ViewportDescription; 79 struct ViewportDescription;
79 struct WebPoint; 80 struct WebPoint;
80 struct WindowFeatures; 81 struct WindowFeatures;
81 82
82 class CORE_EXPORT ChromeClient : public HostWindow { 83 class CORE_EXPORT ChromeClient : public HostWindow {
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 // ENABLE(INPUT_MULTIPLE_FIELDS_UI) 190 // ENABLE(INPUT_MULTIPLE_FIELDS_UI)
190 virtual DateTimeChooser* openDateTimeChooser(DateTimeChooserClient*, const D ateTimeChooserParameters&) = 0; 191 virtual DateTimeChooser* openDateTimeChooser(DateTimeChooserClient*, const D ateTimeChooserParameters&) = 0;
191 192
192 virtual void openTextDataListChooser(HTMLInputElement&)= 0; 193 virtual void openTextDataListChooser(HTMLInputElement&)= 0;
193 194
194 virtual void openFileChooser(LocalFrame*, PassRefPtr<FileChooser>) = 0; 195 virtual void openFileChooser(LocalFrame*, PassRefPtr<FileChooser>) = 0;
195 196
196 // Asychronous request to enumerate all files in a directory chosen by the u ser. 197 // Asychronous request to enumerate all files in a directory chosen by the u ser.
197 virtual void enumerateChosenDirectory(FileChooser*) = 0; 198 virtual void enumerateChosenDirectory(FileChooser*) = 0;
198 199
199 // Pass 0 as the GraphicsLayer to detach the root layer. 200 // Pass nullptr as the GraphicsLayer to detach the root layer.
200 // This sets the graphics layer for the LocalFrame's WebWidget, if it has 201 // This sets the graphics layer for the LocalFrame's WebWidget, if it has
201 // one. Otherwise it sets it for the WebViewImpl. 202 // one. Otherwise it sets it for the WebViewImpl.
202 virtual void attachRootGraphicsLayer(GraphicsLayer*, LocalFrame* localRoot) = 0; 203 virtual void attachRootGraphicsLayer(GraphicsLayer*, LocalFrame* localRoot) = 0;
203 204
204 // In Slimming Paint v2, called when the paint artifact is updated, to allow 205 // Pass nullptr as the WebLayer to detach the root layer.
205 // the underlying web widget to composite it. 206 // This sets the WebLayer for the LocalFrame's WebWidget, if it has
206 virtual void didPaint(const PaintArtifact&) { } 207 // one. Otherwise it sets it for the WebViewImpl.
208 virtual void attachRootLayer(WebLayer*, LocalFrame* localRoot) = 0;
207 209
208 virtual void attachCompositorAnimationTimeline(CompositorAnimationTimeline*, LocalFrame* localRoot) { } 210 virtual void attachCompositorAnimationTimeline(CompositorAnimationTimeline*, LocalFrame* localRoot) { }
209 virtual void detachCompositorAnimationTimeline(CompositorAnimationTimeline*, LocalFrame* localRoot) { } 211 virtual void detachCompositorAnimationTimeline(CompositorAnimationTimeline*, LocalFrame* localRoot) { }
210 212
211 virtual void enterFullscreenForElement(Element*) { } 213 virtual void enterFullscreenForElement(Element*) { }
212 virtual void exitFullscreenForElement(Element*) { } 214 virtual void exitFullscreenForElement(Element*) { }
213 215
214 virtual void clearCompositedSelection(LocalFrame*) { } 216 virtual void clearCompositedSelection(LocalFrame*) { }
215 virtual void updateCompositedSelection(LocalFrame*, const CompositedSelectio n&) { } 217 virtual void updateCompositedSelection(LocalFrame*, const CompositedSelectio n&) { }
216 218
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 305
304 LayoutPoint m_lastToolTipPoint; 306 LayoutPoint m_lastToolTipPoint;
305 String m_lastToolTipText; 307 String m_lastToolTipText;
306 308
307 FRIEND_TEST_ALL_PREFIXES(ChromeClientTest, SetToolTipFlood); 309 FRIEND_TEST_ALL_PREFIXES(ChromeClientTest, SetToolTipFlood);
308 }; 310 };
309 311
310 } // namespace blink 312 } // namespace blink
311 313
312 #endif // ChromeClient_h 314 #endif // ChromeClient_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698