Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: telemetry/telemetry/internal/results/results_options.py

Issue 2342023005: Outputting chart json for disabled tests. (Closed)
Patch Set: Responding to review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/results/results_options.py
diff --git a/telemetry/telemetry/internal/results/results_options.py b/telemetry/telemetry/internal/results/results_options.py
index 3fbeb8495fb39d1a001ebb1e11c170d7f1b1ba6d..1dd130625fa84230e3f5fc10cd07ac431e224039 100644
--- a/telemetry/telemetry/internal/results/results_options.py
+++ b/telemetry/telemetry/internal/results/results_options.py
@@ -112,6 +112,15 @@ def _GetProgressReporter(output_skipped_tests_summary, suppress_gtest_report):
return gtest_progress_reporter.GTestProgressReporter(
sys.stdout, output_skipped_tests_summary=output_skipped_tests_summary)
+def FormatDisabledResults(benchmark_metadata, options):
+ if not options.output_formats:
+ # We only output disabled results for chartjson
+ return
+
+ if 'chartjson' in options.output_formats:
nednguyen 2016/09/22 13:24:33 We should use polymorphism to handle this instead
eyaich1 2016/09/26 14:23:09 Done.
+ output_stream = _GetOutputStream('chartjson', options.output_dir)
+ chart_json_output_formatter.ChartJsonOutputFormatter(
+ output_stream, benchmark_metadata).FormatDisabled()
def CreateResults(benchmark_metadata, options,
value_can_be_added_predicate=lambda v, is_first: True):

Powered by Google App Engine
This is Rietveld 408576698