Outputting chart json for disabled tests.

telemetry/telemetry/internal/story_runner.py

Index: telemetry/telemetry/internal/story_runner.py
diff --git a/telemetry/telemetry/internal/story_runner.py b/telemetry/telemetry/internal/story_runner.py
index 42f2841264342016d18aead8e7286e9e98bd54d5..3382482eeebc41f9c2a91d44e977aa8fd1192630 100644
--- a/telemetry/telemetry/internal/story_runner.py
+++ b/telemetry/telemetry/internal/story_runner.py
@@ -289,6 +289,11 @@ def RunBenchmark(benchmark, finder_options):
     else:
       logging.warning(
           'Try --also-run-disabled-tests to force the benchmark to run.')
+      # If chartjson is specified, this will print a dict indicating the
+      # benchmark name and disabled state.  crrev.com/2265423005 will update
+      # this return value once this logic is plumbed through the recipe.
+      results_options.FormatDisabledResults(

[nednguyen, 2016/09/22 13:24:34]

Instead of using results_options, I think it would make fit better to move the
logic to the results object.
i.e:
 with results_options.CreateResults(benchmark_metadata, finder_options,
benchmark.ValueCanBeAddedPredicate) as results:
   results.FormatDisabledResults()
   return 1


This would allow different outputformatters to define how they want to format
the disabled benchmark results. You can leave everything empty for now, and just
implement it in chart_json_output_formatter

[eyaich1, 2016/09/26 14:23:09]

Done.

+        benchmark.GetMetadata(), finder_options)
       return 1
 
   pt = benchmark.CreatePageTest(finder_options)