Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2342013002: Revert of [worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy. (Closed)

Created:
4 years, 3 months ago by Yuta Kitamura
Modified:
4 years, 3 months ago
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, falken, blink-worker-reviews_chromium.org, darktears, blink-reviews, horo+watch_chromium.org, kinuko+worker_chromium.org, Eric Willigers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy. (patchset #8 id:180001 of https://codereview.chromium.org/2312493002/ ) Reason for revert: Caused leaks in a number of layout tests. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/22941 Original issue's description: > [worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy. > > This patch does the plumbing from the animationworklet to the globalscope to import scripts etc. > > BUG=567358 > > Committed: https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8 > Cr-Commit-Position: refs/heads/master@{#418765} TBR=nhiroki@chromium.org,hongchan@chromium.org,yhirano@chromium.org,majidvp@chromium.org,ikilpatrick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=567358 Committed: https://crrev.com/43271670088ea8fa31ff8151670fb000d0b0f613 Cr-Commit-Position: refs/heads/master@{#418799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -376 lines) Patch
D third_party/WebKit/LayoutTests/http/tests/worklet/animation-worklet-import.html View 1 chunk +0 lines, -13 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/worklet/import.html View 1 chunk +51 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/worklet/paint-worklet-import.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/worklet/resources/import-tests.js View 1 chunk +0 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/core/workers/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScopeProxy.h View 1 chunk +8 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.h View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.h View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp View 2 chunks +3 lines, -8 lines 0 comments Download
D third_party/WebKit/Source/modules/compositorworker/AnimationWorkletMessagingProxy.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/Source/modules/compositorworker/AnimationWorkletMessagingProxy.cpp View 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yuta Kitamura
Created Revert of [worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy.
4 years, 3 months ago (2016-09-15 07:39:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342013002/1
4 years, 3 months ago (2016-09-15 07:39:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 07:40:55 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/43271670088ea8fa31ff8151670fb000d0b0f613 Cr-Commit-Position: refs/heads/master@{#418799}
4 years, 3 months ago (2016-09-15 07:42:34 UTC) #7
haraken
LGTM to revert
4 years, 3 months ago (2016-09-15 07:45:22 UTC) #8
ikilpatrick
4 years, 3 months ago (2016-09-15 15:45:18 UTC) #9
Message was sent while issue was closed.
On 2016/09/15 07:45:22, haraken wrote:
> LGTM to revert

lgtm, Thanks for the revert.

Powered by Google App Engine
This is Rietveld 408576698