third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h - Issue 2342013002: Revert of [worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

Issue 2342013002: Revert of [worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp ('k') | third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

diff --git a/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h b/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

index cbb75791952925d26fd7c3fefa697f9f285a3c2a..c77fd8fe5ecdcdd55ad5dedacdb75c5382f31b4a 100644

--- a/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

+++ b/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h

@@ -12,7 +12,7 @@

namespace blink {

class LocalFrame;

-class ThreadedWorkletMessagingProxy;

+class ThreadedWorkletGlobalScopeProxy;

class WorkletGlobalScopeProxy;

class MODULES_EXPORT AnimationWorklet final : public Worklet {

@@ -28,9 +28,8 @@

private:

explicit AnimationWorklet(LocalFrame*);

- // The proxy outlives the worklet as it is used to perform thread shutdown,

- // it deletes itself once this has occured.

- ThreadedWorkletMessagingProxy* const m_workletMessagingProxy;

+ // TODO(ikilpatrick): this will change to a raw ptr once we have a thread.

+ std::unique_ptr<ThreadedWorkletGlobalScopeProxy> m_workletGlobalScopeProxy;

};

} // namespace blink