Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2341963008: Don't silence deprecation warning (Closed)

Created:
4 years, 3 months ago by lpromero
Modified:
3 years, 7 months ago
Reviewers:
Nico, sdefresne
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't silence deprecation warning Deprecation warnings in third-party code are informational. When they arise, do not silence them (since we treat warnings as errors, these were erroring). Instead, allow the warnings to go through, as warnings. BUG=none R=sdefresne@chromium.org Committed: https://crrev.com/1d3da33267d68f0266f9439f50911efaad5175c9 Cr-Commit-Position: refs/heads/master@{#419169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/third_party/gcdwebserver/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
lpromero
4 years, 3 months ago (2016-09-16 13:48:48 UTC) #1
sdefresne
lgtm
4 years, 3 months ago (2016-09-16 14:28:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341963008/1
4 years, 3 months ago (2016-09-16 14:49:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 14:56:32 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1d3da33267d68f0266f9439f50911efaad5175c9 Cr-Commit-Position: refs/heads/master@{#419169}
4 years, 3 months ago (2016-09-16 14:59:24 UTC) #11
Nico
This does not lgtm, see comment on https://codereview.chromium.org/2579003003/ (and https://codereview.chromium.org/2784063002/diff/180001/build/config/fuchsia/BUILD.gn#newcode16).
3 years, 7 months ago (2017-05-11 16:39:03 UTC) #13
lpromero
3 years, 7 months ago (2017-05-23 11:30:55 UTC) #14
Message was sent while issue was closed.
On 2017/05/11 16:39:03, Nico wrote:
> This does not lgtm, see comment on https://codereview.chromium.org/2579003003/
> (and
>
https://codereview.chromium.org/2784063002/diff/180001/build/config/fuchsia/B...).

https://codereview.chromium.org/2897013002/ to address.

Powered by Google App Engine
This is Rietveld 408576698