Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/md_history/synced_device_manager.js

Issue 2341923005: MD WebUI: Make cr-lazy-render get() synchronous (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_history/list_container.js ('k') | chrome/test/data/webui/cr_elements/cr_lazy_render_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_history/synced_device_manager.js
diff --git a/chrome/browser/resources/md_history/synced_device_manager.js b/chrome/browser/resources/md_history/synced_device_manager.js
index e887a0ef7ad85f7acb5237e54a391a690f0f35b4..476d8a2129f13531021b58ada2f06bdbf8607e14 100644
--- a/chrome/browser/resources/md_history/synced_device_manager.js
+++ b/chrome/browser/resources/md_history/synced_device_manager.js
@@ -134,14 +134,13 @@ Polymer({
},
onToggleMenu_: function(e) {
- this.$.menu.get().then(function(menu) {
- menu.toggleMenu(e.detail.target, e.detail.tag);
- if (menu.menuOpen) {
- md_history.BrowserService.getInstance().recordHistogram(
- SYNCED_TABS_HISTOGRAM_NAME, SyncedTabsHistogram.SHOW_SESSION_MENU,
- SyncedTabsHistogram.LIMIT);
- }
- });
+ var menu = /** @type {CrSharedMenuElement} */ this.$.menu.get();
+ menu.toggleMenu(e.detail.target, e.detail.tag);
+ if (menu.menuOpen) {
+ md_history.BrowserService.getInstance().recordHistogram(
+ SYNCED_TABS_HISTOGRAM_NAME, SyncedTabsHistogram.SHOW_SESSION_MENU,
+ SyncedTabsHistogram.LIMIT);
+ }
},
onOpenAllTap_: function() {
« no previous file with comments | « chrome/browser/resources/md_history/list_container.js ('k') | chrome/test/data/webui/cr_elements/cr_lazy_render_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698