third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h - Issue 2341923002: Harmonize FilterEffect::mapRect and mapPaintRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h

Issue 2341923002: Harmonize FilterEffect::mapRect and mapPaintRect (Closed)

Patch Set: Baselines (again) Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp ('K') | « third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp » ('j') | third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h b/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h

index e12509bd549744497993d9e4e95e0f2ea662058a..930b90708b7eace0309fec37e1b0a182ad74ce9d 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h

@@ -50,14 +50,14 @@ public:

bool setEdgeMode(EdgeModeType);

bool setPreserveAlpha(bool);

- FloatRect mapPaintRect(const FloatRect&, bool forward = true) const final;

TextStream& externalRepresentation(TextStream&, int indention) const override;

private:

FEConvolveMatrix(Filter*, const IntSize&, float, float,

const IntPoint&, EdgeModeType, bool, const Vector<float>&);

+ FloatRect mapEffect(const FloatRect&) const final;

sk_sp<SkImageFilter> createImageFilter() override;

bool parametersValid() const;