third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.cpp - Issue 2341923002: Harmonize FilterEffect::mapRect and mapPaintRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.cpp

Issue 2341923002: Harmonize FilterEffect::mapRect and mapPaintRect (Closed)

Patch Set: Baselines (again) Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp ('K') | « third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.h ('k') | third_party/WebKit/Source/platform/graphics/filters/FEComposite.h » ('j') | third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.cpp

index 824c04f6e7fba2ba7abd325a57cc74c3f16e55d7..ea41cd58f73b4b30c8d2bdba618720586c5cf2c1 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.cpp

@@ -20,7 +20,7 @@ FEBoxReflect::~FEBoxReflect()

{

}

-FloatRect FEBoxReflect::mapRect(const FloatRect& rect, bool forward) const

+FloatRect FEBoxReflect::mapEffect(const FloatRect& rect) const

{

// Reflection about any line is self-inverse, so this for both forward and

Stephen White 2016/09/20 15:36:19 Nit: probably could remove this comment, since we

fs 2016/09/20 19:14:14 Removed.

// reverse mapping.