Add chrome://vr-shell-ui internal page

Add chrome://vr-shell-ui internal page

See design doc in the following link on why we need this page:
All the webui functions are NOTIMPLEMENTED at the moment.
They need some files in https://codereview.chromium.org/2335643002/
before they can be implemented.
To support fast prototyping that requested by UX, this CL
also support override the internal page with remote pages.
So UI can be developed without rebuild Chrome.
That feature is behind enable_vr_shell_ui_dev build flag. We
don't have plan to turn the build flag on.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f85ba713744e00daa978a5db6083561494dda660
Cr-Commit-Position: refs/heads/master@{#419431}

[bshe, 2016-09-14 20:51:37]

Description was changed from

==========
Add chrome://vr-shell-ui internal page


BUG=
==========

to

==========
Add chrome://vr-shell-ui internal page


BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[bshe, 2016-09-15 18:23:15]

The CQ bit was checked by bshe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 18:23:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bshe, 2016-09-15 18:27:22]

Description was changed from

==========
Add chrome://vr-shell-ui internal page


BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add chrome://vr-shell-ui internal page

See design doc in the following link on why we need this page:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...
To support fast prototyping that requested by UX, this CL
also support override the internal page with remote pages.
That feature is guarded behind enable_vr_shell_ui_dev build
flag. We don't have plan to turn the build flag on by default.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-15 18:34:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 18:34:48]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Dan Beam, 2016-09-15 20:28:38]

On 2016/09/15 18:34:48, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

this should be fixed now ^

[bshe, 2016-09-15 20:56:24]

Description was changed from

==========
Add chrome://vr-shell-ui internal page

See design doc in the following link on why we need this page:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...
To support fast prototyping that requested by UX, this CL
also support override the internal page with remote pages.
That feature is guarded behind enable_vr_shell_ui_dev build
flag. We don't have plan to turn the build flag on by default.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add chrome://vr-shell-ui internal page

See design doc in the following link on why we need this page:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...
All the webui functions are NOTIMPLEMENTED at the moment.
They need some files in https://codereview.chromium.org/2335643002/
before they can be implemented.
To support fast prototyping that requested by UX, this CL
also support override the internal page with remote pages.
That feature is behind enable_vr_shell_ui_dev build flag. We
don't have plan to turn the build flag on.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[bshe, 2016-09-15 21:53:43]

Description was changed from

==========
Add chrome://vr-shell-ui internal page

See design doc in the following link on why we need this page:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...
All the webui functions are NOTIMPLEMENTED at the moment.
They need some files in https://codereview.chromium.org/2335643002/
before they can be implemented.
To support fast prototyping that requested by UX, this CL
also support override the internal page with remote pages.
That feature is behind enable_vr_shell_ui_dev build flag. We
don't have plan to turn the build flag on.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add chrome://vr-shell-ui internal page

See design doc in the following link on why we need this page:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...
All the webui functions are NOTIMPLEMENTED at the moment.
They need some files in https://codereview.chromium.org/2335643002/
before they can be implemented.
To support fast prototyping that requested by UX, this CL
also support override the internal page with remote pages.
So UI can be developed without rebuild Chrome.
That feature is behind enable_vr_shell_ui_dev build flag. We
don't have plan to turn the build flag on.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[bshe, 2016-09-15 22:02:11]

bshe@chromium.org changed reviewers:
+ xiyuan@chromium.org

[bshe, 2016-09-15 22:02:11]

Hi Xiyuan.

Do you mind to take a look at this CL? Please feel free to ping me if you have
any question.

Thanks!

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/resource...
chrome/browser/resources/vr_shell/vr_shell_ui.js:72: */
I know I didn't quite follow closure jsdoc requirement in this file. But this
file is actually just placer holder currently and are subjected to lots of
changes. So I didn't bother to change these comments. 
But if you feel strongly that we should follow the style. I can make the change.

[xiyuan, 2016-09-15 22:58:48]

Mostly nits

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/resource...
chrome/browser/resources/vr_shell/vr_shell_ui.js:153:
document.body.parentNode.style.backgroundColor = 'rgba(255,255,255,0)';
Can this be in css to replace
  rgba(255, 255, 255, 0.2)
for html ?

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/resource...
chrome/browser/resources/vr_shell/vr_shell_ui.js:183: b.innerHTML =
buttons[i][0];
nit: innerHTML -> textContent ?

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/resource...
chrome/browser/resources/vr_shell/vr_shell_ui.js:193: var el1 = new UiElement(50
* i, 200, 50, 50, buttonWidth, buttonHeight);
nit: why el1? Would there be an el2? If not, we should just call this |el|.

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/resource...
chrome/browser/resources/vr_shell/vr_shell_ui.js:227: function removeMesh(id) {
nit: seems not used.

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right):

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:528: if (url.host()
== chrome::kChromeUIVrShellUIHost)
Just checking, so this would be available only for Android ?

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.h (right):

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.h:15: }  //
namespace base
nit: remove "// namespace base" to be consistent with line 17-19 ? Or add one
for line 19?

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc (right):

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc:11: #if
!defined(ENABLE_VR_SHELL_UI_DEV)
nit: insert an empty line before to make it easier to see

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc:163: StartDataRequest("", 0,
0, callback);
nit: Don't we lose path info with "" ?

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc:188: RemoteDataSource* source
= new RemoteDataSource(profile->GetRequestContext());
nit: Get rid of |source| and fold into the next line.

[mthiesse, 2016-09-16 15:04:07]

mthiesse@chromium.org changed reviewers:
+ mthiesse@chromium.org

[mthiesse, 2016-09-16 15:04:08]

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc (right):

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc:163: StartDataRequest("", 0,
0, callback);
On 2016/09/15 22:58:47, xiyuan wrote:
> nit: Don't we lose path info with "" ?

No, an empty string is what URL fetching passes to request the default resource.
If we failed to find the default resource on localhost, we try to find the
default resource on our UI designer's externally hosted site (This is so that we
can debug with localhost, but also have a fallback for when localhost is
disconnected). Also note that this is all temporary code for rapidly prototyping
our UI, the only source we'll launch with are the resource path files.

[mthiesse, 2016-09-16 15:07:24]

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc (right):

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc:163: StartDataRequest("", 0,
0, callback);
On 2016/09/16 15:04:07, mthiesse wrote:
> On 2016/09/15 22:58:47, xiyuan wrote:
> > nit: Don't we lose path info with "" ?
> 
> No, an empty string is what URL fetching passes to request the default
resource.
> If we failed to find the default resource on localhost, we try to find the
> default resource on our UI designer's externally hosted site (This is so that
we
> can debug with localhost, but also have a fallback for when localhost is
> disconnected). Also note that this is all temporary code for rapidly
prototyping
> our UI, the only source we'll launch with are the resource path files.

Actually, we should be checking here that the path is in fact empty. If the path
is not empty and we've failed to find a file then that's a bug and we should
probably exit (fail a DCHECK).

[bshe, 2016-09-16 18:27:51]

bshe@chromium.org changed reviewers:
+ sky@chromium.org

[bshe, 2016-09-16 18:27:53]

Thanks for review. Could you please take another look?

+ sky for:
chrome/browser/ui/BUILD.gn
chrome/common/BUILD.gn

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/resource...
chrome/browser/resources/vr_shell/vr_shell_ui.js:153:
document.body.parentNode.style.backgroundColor = 'rgba(255,255,255,0)';
On 2016/09/15 22:58:47, xiyuan wrote:
> Can this be in css to replace
>   rgba(255, 255, 255, 0.2)
> for html ?

Had a quick chat with Micheal. It looks like this is needed to update page
transparency.
It wont work if we set the transparency to 0 initially. The transparency has to
be updated
after page load.
Not sure if this is a bug in blink or WAI.

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/resource...
chrome/browser/resources/vr_shell/vr_shell_ui.js:183: b.innerHTML =
buttons[i][0];
On 2016/09/15 22:58:47, xiyuan wrote:
> nit: innerHTML -> textContent ?

Done.

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/resource...
chrome/browser/resources/vr_shell/vr_shell_ui.js:193: var el1 = new UiElement(50
* i, 200, 50, 50, buttonWidth, buttonHeight);
On 2016/09/15 22:58:47, xiyuan wrote:
> nit: why el1? Would there be an el2? If not, we should just call this |el|.

Done.

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/resource...
chrome/browser/resources/vr_shell/vr_shell_ui.js:227: function removeMesh(id) {
On 2016/09/15 22:58:47, xiyuan wrote:
> nit: seems not used.

Done.

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right):

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:528: if (url.host()
== chrome::kChromeUIVrShellUIHost)
On 2016/09/15 22:58:47, xiyuan wrote:
> Just checking, so this would be available only for Android ?

Correct. We are only targeting Android right now. So keep it only for Android.
When we need to
support other platforms, I will move it outside of OS_ANDROID.

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.h (right):

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.h:15: }  //
namespace base
On 2016/09/15 22:58:47, xiyuan wrote:
> nit: remove "// namespace base" to be consistent with line 17-19 ? Or add one
> for line 19?

Done.

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc (right):

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc:11: #if
!defined(ENABLE_VR_SHELL_UI_DEV)
On 2016/09/15 22:58:47, xiyuan wrote:
> nit: insert an empty line before to make it easier to see

Done.

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc:163: StartDataRequest("", 0,
0, callback);
On 2016/09/16 15:07:24, mthiesse wrote:
> On 2016/09/16 15:04:07, mthiesse wrote:
> > On 2016/09/15 22:58:47, xiyuan wrote:
> > > nit: Don't we lose path info with "" ?
> > 
> > No, an empty string is what URL fetching passes to request the default
> resource.
> > If we failed to find the default resource on localhost, we try to find the
> > default resource on our UI designer's externally hosted site (This is so
that
> we
> > can debug with localhost, but also have a fallback for when localhost is
> > disconnected). Also note that this is all temporary code for rapidly
> prototyping
> > our UI, the only source we'll launch with are the resource path files.
> 
> Actually, we should be checking here that the path is in fact empty. If the
path
> is not empty and we've failed to find a file then that's a bug and we should
> probably exit (fail a DCHECK).

It is easy to make mistakes(such as use a resource before adding it) when
developing.
I don't think using DCHECK is a good idea. We can probably fail silently in that
case and
hopefully devtool could give us error information about the failed request.
I added comment to make this easier to read.

https://codereview.chromium.org/2341803003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc:188: RemoteDataSource* source
= new RemoteDataSource(profile->GetRequestContext());
On 2016/09/15 22:58:47, xiyuan wrote:
> nit: Get rid of |source| and fold into the next line.

Done.

[bshe, 2016-09-16 18:28:14]

The CQ bit was checked by bshe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 18:28:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 19:24:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 19:24:21]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2016-09-16 20:51:39]

https://codereview.chromium.org/2341803003/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc (right):

https://codereview.chromium.org/2341803003/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc:165: pending_.erase(it);
This and L170 should be moved to "delete source" line so that |pending_| is
updated properly.

[bshe, 2016-09-16 21:29:20]

https://codereview.chromium.org/2341803003/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc (right):

https://codereview.chromium.org/2341803003/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc:165: pending_.erase(it);
On 2016/09/16 20:51:39, xiyuan wrote:
> This and L170 should be moved to "delete source" line so that |pending_| is
> updated properly.

Done.

[xiyuan, 2016-09-16 21:30:50]

lgtm

[bshe, 2016-09-16 21:44:53]

The CQ bit was checked by bshe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 21:45:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 22:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 22:51:34]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-16 22:57:31]

https://codereview.chromium.org/2341803003/diff/80001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2341803003/diff/80001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:2192: defines += [ "ENABLE_VR_SHELL_UI_DEV" ]
Why do we need to ifdefs and features? Isn't eanble_vr_shell enough?

https://codereview.chromium.org/2341803003/diff/80001/chrome/common/url_const...
File chrome/common/url_constants.cc (right):

https://codereview.chromium.org/2341803003/diff/80001/chrome/common/url_const...
chrome/common/url_constants.cc:274: #if defined(ENABLE_VR_SHELL)
Isn't the ENABLE_VR_SHELL ifdef enough? By that I mean why do you need this in
OS_ANDROID ifdef?

[bshe, 2016-09-16 23:28:04]

https://codereview.chromium.org/2341803003/diff/80001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2341803003/diff/80001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:2192: defines += [ "ENABLE_VR_SHELL_UI_DEV" ]
On 2016/09/16 22:57:31, sky wrote:
> Why do we need to ifdefs and features? Isn't eanble_vr_shell enough?

enable_vr_shell_ui_dev controls a feature which implemented in 
chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc That file is compiled
when enable_vr_shell is set. So ifdef is needed to conditionally compile some
of the code. enable_vr_shell_ui_dev is a sub flag of enable_vr_shell in a sense.
I can probably divide vr_shell_ui_ui.cc to two files to remove the need for
ifdef if you prefer.

https://codereview.chromium.org/2341803003/diff/80001/chrome/common/url_const...
File chrome/common/url_constants.cc (right):

https://codereview.chromium.org/2341803003/diff/80001/chrome/common/url_const...
chrome/common/url_constants.cc:274: #if defined(ENABLE_VR_SHELL)
On 2016/09/16 22:57:31, sky wrote:
> Isn't the ENABLE_VR_SHELL ifdef enough? By that I mean why do you need this in
> OS_ANDROID ifdef?

You are right. ENABLE_VR_SHELL already requires OS_ANDROID in build file. So
this is
not necessary to include it in OS_ANDROID.

[sky, 2016-09-18 15:59:52]

LGTM

[bshe, 2016-09-19 10:47:02]

The CQ bit was checked by bshe@chromium.org

[bshe, 2016-09-19 10:47:03]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2341803003/#ps100001
(title: "review")

[commit-bot: I haz the power, 2016-09-19 10:47:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 11:43:03]

Description was changed from

==========
Add chrome://vr-shell-ui internal page

See design doc in the following link on why we need this page:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...
All the webui functions are NOTIMPLEMENTED at the moment.
They need some files in https://codereview.chromium.org/2335643002/
before they can be implemented.
To support fast prototyping that requested by UX, this CL
also support override the internal page with remote pages.
So UI can be developed without rebuild Chrome.
That feature is behind enable_vr_shell_ui_dev build flag. We
don't have plan to turn the build flag on.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add chrome://vr-shell-ui internal page

See design doc in the following link on why we need this page:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...
All the webui functions are NOTIMPLEMENTED at the moment.
They need some files in https://codereview.chromium.org/2335643002/
before they can be implemented.
To support fast prototyping that requested by UX, this CL
also support override the internal page with remote pages.
So UI can be developed without rebuild Chrome.
That feature is behind enable_vr_shell_ui_dev build flag. We
don't have plan to turn the build flag on.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-19 11:43:04]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-19 11:44:33]

Description was changed from

==========
Add chrome://vr-shell-ui internal page

See design doc in the following link on why we need this page:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...
All the webui functions are NOTIMPLEMENTED at the moment.
They need some files in https://codereview.chromium.org/2335643002/
before they can be implemented.
To support fast prototyping that requested by UX, this CL
also support override the internal page with remote pages.
So UI can be developed without rebuild Chrome.
That feature is behind enable_vr_shell_ui_dev build flag. We
don't have plan to turn the build flag on.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add chrome://vr-shell-ui internal page

See design doc in the following link on why we need this page:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...
All the webui functions are NOTIMPLEMENTED at the moment.
They need some files in https://codereview.chromium.org/2335643002/
before they can be implemented.
To support fast prototyping that requested by UX, this CL
also support override the internal page with remote pages.
So UI can be developed without rebuild Chrome.
That feature is behind enable_vr_shell_ui_dev build flag. We
don't have plan to turn the build flag on.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f85ba713744e00daa978a5db6083561494dda660
Cr-Commit-Position: refs/heads/master@{#419431}
==========

[commit-bot: I haz the power, 2016-09-19 11:44:34]

Patchset 6 (id:??) landed as
https://crrev.com/f85ba713744e00daa978a5db6083561494dda660
Cr-Commit-Position: refs/heads/master@{#419431}

[mthiesse, 2017-03-15 15:30:06]

Description was changed from

==========
Add chrome://vr-shell-ui internal page

See design doc in the following link on why we need this page:
https://docs.google.com/document/d/1V9_Xj3MYQ4d_MT30ZpXsdqFoFSJXEvQeMNgXcP5SX...
All the webui functions are NOTIMPLEMENTED at the moment.
They need some files in https://codereview.chromium.org/2335643002/
before they can be implemented.
To support fast prototyping that requested by UX, this CL
also support override the internal page with remote pages.
So UI can be developed without rebuild Chrome.
That feature is behind enable_vr_shell_ui_dev build flag. We
don't have plan to turn the build flag on.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f85ba713744e00daa978a5db6083561494dda660
Cr-Commit-Position: refs/heads/master@{#419431}
==========

to

==========
Add chrome://vr-shell-ui internal page

See design doc in the following link on why we need this page:
All the webui functions are NOTIMPLEMENTED at the moment.
They need some files in https://codereview.chromium.org/2335643002/
before they can be implemented.
To support fast prototyping that requested by UX, this CL
also support override the internal page with remote pages.
So UI can be developed without rebuild Chrome.
That feature is behind enable_vr_shell_ui_dev build flag. We
don't have plan to turn the build flag on.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f85ba713744e00daa978a5db6083561494dda660
Cr-Commit-Position: refs/heads/master@{#419431}
==========