Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2341803002: Remove CertErrors::Add(); use CertErrors::AddError() instead. (Closed)

Created:
4 years, 3 months ago by eroman
Modified:
4 years, 3 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CertErrors::Add(); use CertErrors::AddError() instead. BUG=634443 Committed: https://crrev.com/2fb4408cce224d8664d05fb5f9c6c8938a865079 Cr-Commit-Position: refs/heads/master@{#418671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -27 lines) Patch
M net/cert/internal/cert_errors.h View 2 chunks +1 line, -5 lines 0 comments Download
M net/cert/internal/cert_errors.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/cert/internal/signature_policy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/cert/internal/verify_certificate_chain.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M net/cert/internal/verify_signed_data.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
eroman
4 years, 3 months ago (2016-09-14 17:40:59 UTC) #3
mattm
lgtm
4 years, 3 months ago (2016-09-14 20:41:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341803002/1
4 years, 3 months ago (2016-09-14 20:56:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 21:04:32 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 21:05:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fb4408cce224d8664d05fb5f9c6c8938a865079
Cr-Commit-Position: refs/heads/master@{#418671}

Powered by Google App Engine
This is Rietveld 408576698