Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: net/cert/internal/cert_errors.h

Issue 2341803002: Remove CertErrors::Add(); use CertErrors::AddError() instead. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cert/internal/cert_errors.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/cert_errors.h
diff --git a/net/cert/internal/cert_errors.h b/net/cert/internal/cert_errors.h
index f7b78206ca1e16a353051ab9fed0393fe1e1cc05..a9579ce0c3167adf69d01825a449d7c59de9ba4d 100644
--- a/net/cert/internal/cert_errors.h
+++ b/net/cert/internal/cert_errors.h
@@ -24,7 +24,7 @@
//
// * [optional] Child nodes.
//
-// Error nodes are arranged in a tree. The parent/child hiearchy is used to
+// Error nodes are arranged in a tree. The parent/child hierarchy is used to
// group errors that share some common state.
// For instance during path processing it is useful to group the
// errors/warnings that happened while processing certificate "i" as
@@ -125,10 +125,6 @@ class NET_EXPORT CertErrors {
CertErrorId id,
std::unique_ptr<CertErrorParams> params);
- // TODO(crbug.com/634443): Eliminate this and use AddError() instead (which
- // is less ambiguous).
- void Add(CertErrorId id);
-
void AddError(CertErrorId id, std::unique_ptr<CertErrorParams> params);
void AddError(CertErrorId id);
« no previous file with comments | « no previous file | net/cert/internal/cert_errors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698