Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2341783002: Fix an AutoplayUmaHelper crash (Closed)

Created:
4 years, 3 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 3 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an AutoplayUmaHelper crash There is a crash which happens when AutoplayUmaHelper receives unload event from window, but m_element is already garbage collected. This CL fixes this crash by making Element as a Member of AutoplayerUmaHelper. BUG=646890 R=avayvod@chromium.org,mlamouri@chromium.org Committed: https://crrev.com/e8cefaed4ed3209886bc4a62df0b67c6f66ece81 Cr-Commit-Position: refs/heads/master@{#418659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/AutoplayUmaHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Zhiqiang Zhang (Slow)
4 years, 3 months ago (2016-09-14 16:28:36 UTC) #2
mlamouri (slow - plz ping)
lgtm
4 years, 3 months ago (2016-09-14 17:14:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341783002/1
4 years, 3 months ago (2016-09-14 20:24:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 20:31:18 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 20:34:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8cefaed4ed3209886bc4a62df0b67c6f66ece81
Cr-Commit-Position: refs/heads/master@{#418659}

Powered by Google App Engine
This is Rietveld 408576698