third_party/WebKit/Source/core/html/AutoplayUmaHelper.h - Issue 2341783002: Fix an AutoplayUmaHelper crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/AutoplayUmaHelper.h

Issue 2341783002: Fix an AutoplayUmaHelper crash (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/AutoplayUmaHelper.h

diff --git a/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h b/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h

index ec299d309ed55f3d13fca727ea6493d041171aa1..9228bf44c4c2a04ac3890dfcfcb6087035c360ed 100644

--- a/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h

+++ b/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h

@@ -81,7 +81,7 @@ private:

// The autoplay source. Use AutoplaySource::NumberOfSources for invalid source.

AutoplaySource m_source;

// The media element this UMA helper is attached to. |m_element| owns |this|.

- WeakMember<HTMLMediaElement> m_element;

+ Member<HTMLMediaElement> m_element;

// The observer is used to observe whether a muted video autoplaying by play()

// method become visible at some point.

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp » ('j') | no next file with comments »