Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2341773004: Fix 'chrome' build when use_ozone is true (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 2 weeks ago by tonikitoo
Modified:
9 months, 2 weeks ago
CC:
chromium-reviews, fwang, dvadym, vabr (Chromium)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 'chrome' build when use_ozone is true As is, the 'chrome' target depends on libsecret, which explicitly depends on glib. In case of use_ozone=true builds, though, use_glib is set to false. CL fixes it by not building libsecret dependant files when use_ozone is true. Committed: https://crrev.com/e1ac59e44d680d11f9978c010eeb4c44a092111e Cr-Commit-Position: refs/heads/master@{#418663}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix 'chrome' build when use_ozone is true #

Messages

Total messages: 13 (7 generated)
tonikitoo
PTAL
9 months, 2 weeks ago (2016-09-14 18:05:27 UTC) #2
Nico (vacation Jun 30-Jul 11)
lgtm https://codereview.chromium.org/2341773004/diff/1/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (right): https://codereview.chromium.org/2341773004/diff/1/chrome/browser/BUILD.gn#newcode3435 chrome/browser/BUILD.gn:3435: # Desktop linux, doesn"t count ChromeOS. can you ...
9 months, 2 weeks ago (2016-09-14 18:17:12 UTC) #4
tonikitoo
https://codereview.chromium.org/2341773004/diff/1/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (right): https://codereview.chromium.org/2341773004/diff/1/chrome/browser/BUILD.gn#newcode3435 chrome/browser/BUILD.gn:3435: # Desktop linux, doesn"t count ChromeOS. On 2016/09/14 18:17:12, ...
9 months, 2 weeks ago (2016-09-14 18:56:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341773004/20001
9 months, 2 weeks ago (2016-09-14 18:57:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
9 months, 2 weeks ago (2016-09-14 20:45:01 UTC) #11
commit-bot: I haz the power
9 months, 2 weeks ago (2016-09-14 20:47:22 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1ac59e44d680d11f9978c010eeb4c44a092111e
Cr-Commit-Position: refs/heads/master@{#418663}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318