Fix 'chrome' build when use_ozone is true

Fix 'chrome' build when use_ozone is true

As is, the 'chrome' target depends on libsecret, which
explicitly depends on glib.
In case of use_ozone=true builds, though, use_glib is
set to false.

CL fixes it by not building libsecret dependant files
when use_ozone is true.

Committed: https://crrev.com/e1ac59e44d680d11f9978c010eeb4c44a092111e
Cr-Commit-Position: refs/heads/master@{#418663}

[tonikitoo, 2016-09-14 18:05:26]

tonikitoo@igalia.com changed reviewers:
+ cpu@chromium.org, jochen@chromium.org, thakis@chromium.org,
thestig@chromium.org

[tonikitoo, 2016-09-14 18:05:27]

PTAL

[tonikitoo, 2016-09-14 18:05:45]

Description was changed from

==========
Fix 'chrome' build when use_ozone is true

As is, the 'chrome' target depends on libsecret, which
explicitly depends on glib.
In case of use_ozone=true builds, glib is disabled.

CL fixes it by not building libsecret dependant files
when use_ozone is true.
==========

to

==========
Fix 'chrome' build when use_ozone is true

As is, the 'chrome' target depends on libsecret, which
explicitly depends on glib.
In case of use_ozone=true builds, glib is disabled.

CL fixes it by not building libsecret dependant files
when use_ozone is true.
==========

[Nico, 2016-09-14 18:17:12]

lgtm

https://codereview.chromium.org/2341773004/diff/1/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/2341773004/diff/1/chrome/browser/BUILD.gn#new...
chrome/browser/BUILD.gn:3435: # Desktop linux, doesn"t count ChromeOS.
can you fix the quote char here while you're in the vicinity? (sorry)

https://codereview.chromium.org/2341773004/diff/1/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2341773004/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:4325: if (is_linux && !is_chromeos && !use_ozone) {
should this check is_desktop_linux like the non-text gn file?

[tonikitoo, 2016-09-14 18:56:22]

Description was changed from

==========
Fix 'chrome' build when use_ozone is true

As is, the 'chrome' target depends on libsecret, which
explicitly depends on glib.
In case of use_ozone=true builds, glib is disabled.

CL fixes it by not building libsecret dependant files
when use_ozone is true.
==========

to

==========
Fix 'chrome' build when use_ozone is true
    
As is, the 'chrome' target depends on libsecret, which
explicitly depends on glib.
In case of use_ozone=true builds, though, use_glib is
set to false.
    
CL fixes it by not building libsecret dependant files
when use_ozone is true.
==========

[tonikitoo, 2016-09-14 18:56:44]

https://codereview.chromium.org/2341773004/diff/1/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/2341773004/diff/1/chrome/browser/BUILD.gn#new...
chrome/browser/BUILD.gn:3435: # Desktop linux, doesn"t count ChromeOS.
On 2016/09/14 18:17:12, Nico wrote:
> can you fix the quote char here while you're in the vicinity? (sorry)

Done.

https://codereview.chromium.org/2341773004/diff/1/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2341773004/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:4325: if (is_linux && !is_chromeos && !use_ozone) {
On 2016/09/14 18:17:12, Nico wrote:
> should this check is_desktop_linux like the non-text gn file?

I believe so. I will follow up on this, so that we keep this CL atomic.

[tonikitoo, 2016-09-14 18:56:52]

The CQ bit was checked by tonikitoo@igalia.com

[tonikitoo, 2016-09-14 18:56:53]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2341773004/#ps20001
(title: "Fix 'chrome' build when use_ozone is true")

[commit-bot: I haz the power, 2016-09-14 18:57:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 20:45:00]

Description was changed from

==========
Fix 'chrome' build when use_ozone is true
    
As is, the 'chrome' target depends on libsecret, which
explicitly depends on glib.
In case of use_ozone=true builds, though, use_glib is
set to false.
    
CL fixes it by not building libsecret dependant files
when use_ozone is true.
==========

to

==========
Fix 'chrome' build when use_ozone is true
    
As is, the 'chrome' target depends on libsecret, which
explicitly depends on glib.
In case of use_ozone=true builds, though, use_glib is
set to false.
    
CL fixes it by not building libsecret dependant files
when use_ozone is true.
==========

[commit-bot: I haz the power, 2016-09-14 20:45:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-14 20:47:21]

Description was changed from

==========
Fix 'chrome' build when use_ozone is true
    
As is, the 'chrome' target depends on libsecret, which
explicitly depends on glib.
In case of use_ozone=true builds, though, use_glib is
set to false.
    
CL fixes it by not building libsecret dependant files
when use_ozone is true.
==========

to

==========
Fix 'chrome' build when use_ozone is true

As is, the 'chrome' target depends on libsecret, which
explicitly depends on glib.
In case of use_ozone=true builds, though, use_glib is
set to false.

CL fixes it by not building libsecret dependant files
when use_ozone is true.

Committed: https://crrev.com/e1ac59e44d680d11f9978c010eeb4c44a092111e
Cr-Commit-Position: refs/heads/master@{#418663}
==========

[commit-bot: I haz the power, 2016-09-14 20:47:22]

Patchset 2 (id:??) landed as
https://crrev.com/e1ac59e44d680d11f9978c010eeb4c44a092111e
Cr-Commit-Position: refs/heads/master@{#418663}