Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2341773003: Add Some Comments to the Timeout Checks on Condition Variables (Closed)

Created:
4 years, 3 months ago by robliao
Modified:
4 years, 3 months ago
Reviewers:
danakj, sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Some Comments to the Timeout Checks on Condition Variables BUG=619037 Committed: https://crrev.com/4197b46757b395687234c3a49e6775143b4f5b42 Cr-Commit-Position: refs/heads/master@{#418655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M base/synchronization/condition_variable_posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/synchronization/condition_variable_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
robliao
Please review this CL. Thanks!
4 years, 3 months ago (2016-09-14 17:49:50 UTC) #4
sky
LGTM
4 years, 3 months ago (2016-09-14 18:06:11 UTC) #5
danakj
LGTM
4 years, 3 months ago (2016-09-14 20:09:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341773003/1
4 years, 3 months ago (2016-09-14 20:12:27 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 20:22:08 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 20:23:34 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4197b46757b395687234c3a49e6775143b4f5b42
Cr-Commit-Position: refs/heads/master@{#418655}

Powered by Google App Engine
This is Rietveld 408576698