Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Unified Diff: third_party/WebKit/LayoutTests/gamepad/gamepad-polling-access.html

Issue 2341723002: binding: Indexed property returns undefined if out-of-range. (Closed)
Patch Set: Updated layout test expectations. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/gamepad/gamepad-polling-access.html
diff --git a/third_party/WebKit/LayoutTests/gamepad/gamepad-polling-access.html b/third_party/WebKit/LayoutTests/gamepad/gamepad-polling-access.html
index 9bc59a50000bf0ea0e608d7e1eaaa4d61e4238d7..d7128ccce6f76b43f7d731ceacaafb6977d37919 100644
--- a/third_party/WebKit/LayoutTests/gamepad/gamepad-polling-access.html
+++ b/third_party/WebKit/LayoutTests/gamepad/gamepad-polling-access.html
@@ -14,17 +14,17 @@
shouldBeNull("navigator.getGamepads().item(1)");
shouldBeNull("navigator.getGamepads().item(2)");
shouldBeNull("navigator.getGamepads().item(3)");
- shouldBeUndefined("navigator.getGamepads()[0]");
- shouldBeUndefined("navigator.getGamepads()[1]");
- shouldBeUndefined("navigator.getGamepads()[2]");
- shouldBeUndefined("navigator.getGamepads()[3]");
+ shouldBeNull("navigator.getGamepads()[0]");
+ shouldBeNull("navigator.getGamepads()[1]");
+ shouldBeNull("navigator.getGamepads()[2]");
+ shouldBeNull("navigator.getGamepads()[3]");
// connect and disconnect
gamepadController.connect(0);
shouldBeNonNull("navigator.getGamepads()[0]");
gamepadController.disconnect(0);
shouldBeNull("navigator.getGamepads().item(0)");
- shouldBeUndefined("navigator.getGamepads()[0]");
+ shouldBeNull("navigator.getGamepads()[0]");
// connect again, and check standard access
gamepadController.connect(0);

Powered by Google App Engine
This is Rietveld 408576698