third_party/WebKit/LayoutTests/gamepad/gamepad-polling-access.html - Issue 2341723002: binding: Indexed property returns undefined if out-of-range.

Side by Side Diff: third_party/WebKit/LayoutTests/gamepad/gamepad-polling-access.html

Issue 2341723002: binding: Indexed property returns undefined if out-of-range. (Closed)

Patch Set: Updated layout test expectations. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/gamepad/gamepad-api-expected.txt ('k') | third_party/WebKit/LayoutTests/gamepad/gamepad-polling-access-expected.txt » ('j') | third_party/WebKit/Source/bindings/templates/interface.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <body>	2 <body>

3 <script src="../resources/js-test.js"></script>	3 <script src="../resources/js-test.js"></script>

4 <script>	4 <script>

5 if (window.gamepadController)	5 if (window.gamepadController)

6 {	6 {

7 // start all disconnected	7 // start all disconnected

8 gamepadController.disconnect(0);	8 gamepadController.disconnect(0);

9 gamepadController.disconnect(1);	9 gamepadController.disconnect(1);

10 gamepadController.disconnect(2);	10 gamepadController.disconnect(2);

11 gamepadController.disconnect(3);	11 gamepadController.disconnect(3);

12 shouldBe("navigator.getGamepads().length", "4");	12 shouldBe("navigator.getGamepads().length", "4");

13 shouldBeNull("navigator.getGamepads().item(0)");	13 shouldBeNull("navigator.getGamepads().item(0)");

14 shouldBeNull("navigator.getGamepads().item(1)");	14 shouldBeNull("navigator.getGamepads().item(1)");

15 shouldBeNull("navigator.getGamepads().item(2)");	15 shouldBeNull("navigator.getGamepads().item(2)");

16 shouldBeNull("navigator.getGamepads().item(3)");	16 shouldBeNull("navigator.getGamepads().item(3)");

17 shouldBeUndefined("navigator.getGamepads()[0]");	17 shouldBeNull("navigator.getGamepads()[0]");

18 shouldBeUndefined("navigator.getGamepads()[1]");	18 shouldBeNull("navigator.getGamepads()[1]");

19 shouldBeUndefined("navigator.getGamepads()[2]");	19 shouldBeNull("navigator.getGamepads()[2]");

20 shouldBeUndefined("navigator.getGamepads()[3]");	20 shouldBeNull("navigator.getGamepads()[3]");

21	21

22 // connect and disconnect	22 // connect and disconnect

23 gamepadController.connect(0);	23 gamepadController.connect(0);

24 shouldBeNonNull("navigator.getGamepads()[0]");	24 shouldBeNonNull("navigator.getGamepads()[0]");

25 gamepadController.disconnect(0);	25 gamepadController.disconnect(0);

26 shouldBeNull("navigator.getGamepads().item(0)");	26 shouldBeNull("navigator.getGamepads().item(0)");

27 shouldBeUndefined("navigator.getGamepads()[0]");	27 shouldBeNull("navigator.getGamepads()[0]");

28	28

29 // connect again, and check standard access	29 // connect again, and check standard access

30 gamepadController.connect(0);	30 gamepadController.connect(0);

31 gamepadController.setId(0, "MockStick 3000");	31 gamepadController.setId(0, "MockStick 3000");

32 gamepadController.setButtonCount(0, 2);	32 gamepadController.setButtonCount(0, 2);

33 gamepadController.setAxisCount(0, 2);	33 gamepadController.setAxisCount(0, 2);

34 gamepadController.setButtonData(0, 0, 1);	34 gamepadController.setButtonData(0, 0, 1);

35 gamepadController.setButtonData(0, 1, 0);	35 gamepadController.setButtonData(0, 1, 0);

36 gamepadController.setAxisData(0, 0, .5);	36 gamepadController.setAxisData(0, 0, .5);

37 gamepadController.setAxisData(0, 1, -1.0);	37 gamepadController.setAxisData(0, 1, -1.0);

38 shouldBe("navigator.getGamepads()[0].id", "'MockStick 3000'");	38 shouldBe("navigator.getGamepads()[0].id", "'MockStick 3000'");

39 shouldBe("navigator.getGamepads()[0].buttons.length", "2");	39 shouldBe("navigator.getGamepads()[0].buttons.length", "2");

40 shouldBe("navigator.getGamepads()[0].axes.length", "2");	40 shouldBe("navigator.getGamepads()[0].axes.length", "2");

41 shouldBe("navigator.getGamepads()[0].buttons[0].value", "1.0");	41 shouldBe("navigator.getGamepads()[0].buttons[0].value", "1.0");

42 shouldBe("navigator.getGamepads()[0].buttons[0].pressed", "true");	42 shouldBe("navigator.getGamepads()[0].buttons[0].pressed", "true");

43 shouldBe("navigator.getGamepads()[0].buttons[1].value", "0.0");	43 shouldBe("navigator.getGamepads()[0].buttons[1].value", "0.0");

44 shouldBe("navigator.getGamepads()[0].buttons[1].pressed", "false");	44 shouldBe("navigator.getGamepads()[0].buttons[1].pressed", "false");

45 shouldBe("navigator.getGamepads()[0].axes.length", "2");	45 shouldBe("navigator.getGamepads()[0].axes.length", "2");

46 shouldBe("navigator.getGamepads()[0].axes[0]", "0.5");	46 shouldBe("navigator.getGamepads()[0].axes[0]", "0.5");

47 shouldBe("navigator.getGamepads()[0].axes[1]", "-1.0");	47 shouldBe("navigator.getGamepads()[0].axes[1]", "-1.0");

48 }	48 }

49 else	49 else

50 {	50 {

51 console.log("FAIL: no gamepadController available.")	51 console.log("FAIL: no gamepadController available.")

52 }	52 }

53 </script>	53 </script>

54 <p>Typical polling access to gamepads contents.</p>	54 <p>Typical polling access to gamepads contents.</p>

55 </body>	55 </body>

OLD	NEW