binding: Indexed property returns undefined if out-of-range.

binding: Indexed property returns undefined if out-of-range.

Makes indexed properties return undefined if the index is out of range.

BUG=229750
Committed: https://crrev.com/9f6cd0eb83b8d3166071dd5d5780b688034e0a61
Cr-Commit-Position: refs/heads/master@{#418816}

[Yuki, 2016-09-14 12:18:08]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 12:18:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 13:39:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 13:39:03]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Yuki, 2016-09-14 14:06:35]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 14:06:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2016-09-14 14:07:12]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuki, 2016-09-14 14:07:12]

Could you review this CL?

[haraken, 2016-09-14 14:45:48]

LGTM

[commit-bot: I haz the power, 2016-09-14 15:23:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 15:23:58]

Dry run: This issue passed the CQ dry run.

[peria, 2016-09-14 15:25:02]

peria@chromium.org changed reviewers:
+ peria@chromium.org

[peria, 2016-09-14 15:25:03]

lgtm

https://codereview.chromium.org/2341723002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/2341723002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/interface.cpp:24: // We assume that
all the implementations support length() method, although
Please use "{#...#}" style comment not to generate code with comments.

[Yuki, 2016-09-15 09:49:17]

https://codereview.chromium.org/2341723002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/2341723002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/interface.cpp:24: // We assume that
all the implementations support length() method, although
On 2016/09/14 15:25:03, peria wrote:
> Please use "{#...#}" style comment not to generate code with comments.

I intentionally made this comment C++ comment so that it's visible to Blink
developers.

If someone implements a new interface (or updates an existing interface) and
hits a compile error that class T does not declare length(), this comment will
be useful for Blink developers to understand why the compile error happens.

[Yuki, 2016-09-15 09:49:27]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2016-09-15 09:49:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 09:55:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-15 09:56:31]

Description was changed from

==========
binding: Indexed property returns undefined if out-of-range.

Makes indexed properties return undefined if the index is out of range.

BUG=229750
==========

to

==========
binding: Indexed property returns undefined if out-of-range.

Makes indexed properties return undefined if the index is out of range.

BUG=229750

Committed: https://crrev.com/9f6cd0eb83b8d3166071dd5d5780b688034e0a61
Cr-Commit-Position: refs/heads/master@{#418816}
==========

[commit-bot: I haz the power, 2016-09-15 09:56:32]

Patchset 2 (id:??) landed as
https://crrev.com/9f6cd0eb83b8d3166071dd5d5780b688034e0a61
Cr-Commit-Position: refs/heads/master@{#418816}