chrome/service/service_process.cc - Issue 2341693002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/service_process.cc

Issue 2341693002: Re-write many calls to WrapUnique() with MakeUnique() (Closed)

Patch Set: Fix one under-change and one mysterious revert Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/service/service_process.cc

diff --git a/chrome/service/service_process.cc b/chrome/service/service_process.cc

index 1f915e3f6ccf4e4357ea657628a150d617bbf1a2..56d8db8e67e80b92ad5e7b6dc85251c53bc5f03a 100644

--- a/chrome/service/service_process.cc

+++ b/chrome/service/service_process.cc

@@ -226,8 +226,9 @@ bool ServiceProcess::Initialize(base::MessageLoopForUI* message_loop,

ipc_server_.reset(new ServiceIPCServer(this /* client */, io_task_runner(),

&shutdown_event_));

- ipc_server_->AddMessageHandler(base::WrapUnique(

- new cloud_print::CloudPrintMessageHandler(ipc_server_.get(), this)));

+ ipc_server_->AddMessageHandler(

+ base::MakeUnique<cloud_print::CloudPrintMessageHandler>(ipc_server_.get(),

+ this));

ipc_server_->Init();

// After the IPC server has started we signal that the service process is