chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc - Issue 2341693002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

Issue 2341693002: Re-write many calls to WrapUnique() with MakeUnique() (Closed)

Patch Set: Fix one under-change and one mysterious revert Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc ('K') | « chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc ('k') | chrome/installer/util/beacons.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

index a3cdc4ef77c529c9d65e107d85ad3835e49c10e8..483b500a0aa780c4306144267aba242e9fe91154 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

@@ -131,7 +131,7 @@ TEST_F(PlatformAppsManifestTest, CertainApisRequirePlatformApps) {

permissions->AppendString(api_name);

manifest->Set("permissions", permissions);

manifests.push_back(

- base::WrapUnique(new ManifestData(manifest->CreateDeepCopy(), "")));

+ base::MakeUnique<ManifestData>(manifest->CreateDeepCopy(), ""));

sky 2016/09/14 17:46:43 "" -> std::string()

Adam Rice 2016/09/15 02:05:55 Done.

Adam Rice 2016/09/15 06:18:56 It didn't compile. The parameter type is actually

sky 2016/09/15 16:57:28 My mistake. Sorry.

}

// First try to load without any flags. This should warn for every API.

for (const std::unique_ptr<ManifestData>& manifest : manifests) {