Re-write many calls to WrapUnique() with MakeUnique()

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

Miscellaneous minor cleanups were applied.

BUG=637812
Committed: https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8
Cr-Commit-Position: refs/heads/master@{#418795}

[Adam Rice, 2016-09-14 09:25:11]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 09:25:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2016-09-14 09:46:41]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 09:47:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2016-09-14 09:54:09]

ricea@chromium.org changed reviewers:
+ sky@chromium.org

[Adam Rice, 2016-09-14 09:54:10]

I checked for unmodified calls to WrapUnique(). There are only two and they are
both of the "can't be changed" variety:

chrome/renderer/extensions/extension_localization_peer.cc:65
chrome/test/chromedriver/commands.cc:322

[commit-bot: I haz the power, 2016-09-14 10:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 10:36:32]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-14 17:46:43]

LGTM

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/chrome_co...
File chrome/common/chrome_content_client.cc (right):

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/chrome_co...
chrome/common/chrome_content_client.cc:723: if (!origin_trial_policy_) {
optional: while here remove {}

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/extension...
File
chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc
(right):

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc:41:
if (page_action_info) {
optional: while here remove {}

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc:46:
return std::unique_ptr<ActionInfo>();
return nullptr?

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/extension...
File
chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
(right):

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/extension...
chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc:134:
base::MakeUnique<ManifestData>(manifest->CreateDeepCopy(), ""));
"" -> std::string()

[Adam Rice, 2016-09-15 02:05:41]

Description was changed from

==========
Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

BUG=637812
==========

to

==========
Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

Miscellaneous minor cleanups were applied.

BUG=637812
==========

[Adam Rice, 2016-09-15 02:05:55]

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/chrome_co...
File chrome/common/chrome_content_client.cc (right):

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/chrome_co...
chrome/common/chrome_content_client.cc:723: if (!origin_trial_policy_) {
On 2016/09/14 17:46:42, sky wrote:
> optional: while here remove {}

Done.

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/extension...
File
chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc
(right):

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc:41:
if (page_action_info) {
On 2016/09/14 17:46:42, sky wrote:
> optional: while here remove {}

Done.

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc:46:
return std::unique_ptr<ActionInfo>();
On 2016/09/14 17:46:43, sky wrote:
> return nullptr?

Done.

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/extension...
File
chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
(right):

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/extension...
chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc:134:
base::MakeUnique<ManifestData>(manifest->CreateDeepCopy(), ""));
On 2016/09/14 17:46:43, sky wrote:
> "" -> std::string()

Done.

[Adam Rice, 2016-09-15 04:20:14]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2016-09-15 04:20:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2341693002/#ps40001
(title: "Nitpick changes")

[commit-bot: I haz the power, 2016-09-15 04:20:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 04:23:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 04:23:05]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Adam Rice, 2016-09-15 06:10:12]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2016-09-15 06:10:12]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2341693002/#ps60001
(title: "Change std::string() back to "" to fix compile")

[commit-bot: I haz the power, 2016-09-15 06:10:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2016-09-15 06:18:56]

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/extension...
File
chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
(right):

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/extension...
chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc:134:
base::MakeUnique<ManifestData>(manifest->CreateDeepCopy(), ""));
On 2016/09/15 02:05:55, Adam Rice wrote:
> On 2016/09/14 17:46:43, sky wrote:
> > "" -> std::string()
> 
> Done.

It didn't compile. The parameter type is actually const char*. I changed it
back.

[commit-bot: I haz the power, 2016-09-15 06:47:50]

Description was changed from

==========
Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

Miscellaneous minor cleanups were applied.

BUG=637812
==========

to

==========
Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

Miscellaneous minor cleanups were applied.

BUG=637812
==========

[commit-bot: I haz the power, 2016-09-15 06:47:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-15 06:51:00]

Description was changed from

==========
Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

Miscellaneous minor cleanups were applied.

BUG=637812
==========

to

==========
Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

Miscellaneous minor cleanups were applied.

BUG=637812

Committed: https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8
Cr-Commit-Position: refs/heads/master@{#418795}
==========

[commit-bot: I haz the power, 2016-09-15 06:51:02]

Patchset 4 (id:??) landed as
https://crrev.com/0c39556939fdc7a522d9092f8a45e783550322c8
Cr-Commit-Position: refs/heads/master@{#418795}

[sky, 2016-09-15 16:57:28]

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/extension...
File
chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
(right):

https://codereview.chromium.org/2341693002/diff/20001/chrome/common/extension...
chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc:134:
base::MakeUnique<ManifestData>(manifest->CreateDeepCopy(), ""));
On 2016/09/15 06:18:56, Adam Rice wrote:
> On 2016/09/15 02:05:55, Adam Rice wrote:
> > On 2016/09/14 17:46:43, sky wrote:
> > > "" -> std::string()
> > 
> > Done.
> 
> It didn't compile. The parameter type is actually const char*. I changed it
> back.

My mistake. Sorry.