Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: chrome/installer/util/browser_distribution.cc

Issue 2341693002: Re-write many calls to WrapUnique() with MakeUnique() (Closed)
Patch Set: Change std::string() back to "" to fix compile Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/util/beacons.cc ('k') | chrome/installer/util/lzma_file_allocator_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file defines a class that contains various method related to branding. 5 // This file defines a class that contains various method related to branding.
6 // It provides only default implementations of these methods. Usually to add 6 // It provides only default implementations of these methods. Usually to add
7 // specific branding, we will need to extend this class with a custom 7 // specific branding, we will need to extend this class with a custom
8 // implementation. 8 // implementation.
9 9
10 #include "chrome/installer/util/browser_distribution.h" 10 #include "chrome/installer/util/browser_distribution.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 BrowserDistribution* g_binaries_distribution = NULL; 48 BrowserDistribution* g_binaries_distribution = NULL;
49 49
50 BrowserDistribution::Type GetCurrentDistributionType() { 50 BrowserDistribution::Type GetCurrentDistributionType() {
51 return BrowserDistribution::CHROME_BROWSER; 51 return BrowserDistribution::CHROME_BROWSER;
52 } 52 }
53 53
54 } // namespace 54 } // namespace
55 55
56 BrowserDistribution::BrowserDistribution() 56 BrowserDistribution::BrowserDistribution()
57 : type_(CHROME_BROWSER), 57 : type_(CHROME_BROWSER),
58 app_reg_data_(base::WrapUnique( 58 app_reg_data_(base::MakeUnique<NonUpdatingAppRegistrationData>(
59 new NonUpdatingAppRegistrationData(L"Software\\Chromium"))) {} 59 L"Software\\Chromium")) {}
60 60
61 BrowserDistribution::BrowserDistribution( 61 BrowserDistribution::BrowserDistribution(
62 Type type, 62 Type type,
63 std::unique_ptr<AppRegistrationData> app_reg_data) 63 std::unique_ptr<AppRegistrationData> app_reg_data)
64 : type_(type), app_reg_data_(std::move(app_reg_data)) {} 64 : type_(type), app_reg_data_(std::move(app_reg_data)) {}
65 65
66 BrowserDistribution::~BrowserDistribution() {} 66 BrowserDistribution::~BrowserDistribution() {}
67 67
68 template<class DistributionClass> 68 template<class DistributionClass>
69 BrowserDistribution* BrowserDistribution::GetOrCreateBrowserDistribution( 69 BrowserDistribution* BrowserDistribution::GetOrCreateBrowserDistribution(
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 installer::InstallStatus install_status) { 255 installer::InstallStatus install_status) {
256 } 256 }
257 257
258 bool BrowserDistribution::ShouldSetExperimentLabels() { 258 bool BrowserDistribution::ShouldSetExperimentLabels() {
259 return false; 259 return false;
260 } 260 }
261 261
262 bool BrowserDistribution::HasUserExperiments() { 262 bool BrowserDistribution::HasUserExperiments() {
263 return false; 263 return false;
264 } 264 }
OLDNEW
« no previous file with comments | « chrome/installer/util/beacons.cc ('k') | chrome/installer/util/lzma_file_allocator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698