Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2341683006: Fix various issues with `gn analyze`. (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix various issues with `gn analyze`. I had the name of one of the input fields wrong, and I had an error case not returning output correctly. R=brettw@chromium.org BUG=555273 Committed: https://crrev.com/ac5096069eaa4a7716f6441a1af04e59b635adb7 Cr-Commit-Position: refs/heads/master@{#419075}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review feedback #

Patch Set 3 : update docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -45 lines) Patch
M tools/gn/analyzer.cc View 1 7 chunks +9 lines, -17 lines 0 comments Download
M tools/gn/analyzer_unittest.cc View 5 chunks +33 lines, -4 lines 0 comments Download
M tools/gn/command_analyze.cc View 1 chunk +11 lines, -12 lines 0 comments Download
M tools/gn/docs/reference.md View 1 2 1 chunk +11 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
4 years, 3 months ago (2016-09-15 23:09:19 UTC) #1
brettw
lgtm https://codereview.chromium.org/2341683006/diff/1/tools/gn/analyzer.cc File tools/gn/analyzer.cc (right): https://codereview.chromium.org/2341683006/diff/1/tools/gn/analyzer.cc#newcode212 tools/gn/analyzer.cc:212: *err = Err(); You don't need this, only ...
4 years, 3 months ago (2016-09-15 23:22:45 UTC) #2
Dirk Pranke
https://codereview.chromium.org/2341683006/diff/1/tools/gn/analyzer.cc File tools/gn/analyzer.cc (right): https://codereview.chromium.org/2341683006/diff/1/tools/gn/analyzer.cc#newcode212 tools/gn/analyzer.cc:212: *err = Err(); On 2016/09/15 23:22:45, brettw (ping on ...
4 years, 3 months ago (2016-09-16 00:11:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341683006/40001
4 years, 3 months ago (2016-09-16 00:22:56 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-16 01:50:26 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 01:53:53 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ac5096069eaa4a7716f6441a1af04e59b635adb7
Cr-Commit-Position: refs/heads/master@{#419075}

Powered by Google App Engine
This is Rietveld 408576698