Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: tools/gn/command_analyze.cc

Issue 2341683006: Fix various issues with `gn analyze`. (Closed)
Patch Set: update docs Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/analyzer_unittest.cc ('k') | tools/gn/docs/reference.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_analyze.cc
diff --git a/tools/gn/command_analyze.cc b/tools/gn/command_analyze.cc
index a9c0d9a7246084437514ef9b8af86b23ddacf3c6..03519cbd4aecec51cd448cb75fe4d2948be18f8d 100644
--- a/tools/gn/command_analyze.cc
+++ b/tools/gn/command_analyze.cc
@@ -34,27 +34,26 @@ const char kAnalyze_Help[] =
"\n"
" - \"files\": A list of the filenames to check.\n"
"\n"
- " - \"compile_targets\": A list of the labels targets that we wish to\n"
- " rebuild, but aren't necessarily needed for testing. The\n"
- " important difference between this field and \"test_targets\"\n"
- " is that if an item in the compile_targets list is a group, then\n"
+ " - \"test_targets\": A list of the labels for targets that\n"
+ " are needed to run the tests we wish to run.\n"
+ "\n"
+ " - \"additional_compile_targets\": A list of the labels for\n"
+ " targets that we wish to rebuild, but aren't necessarily needed\n"
+ " for testing. The important difference between this field and\n"
+ " \"test_targets\" is that if an item in the\n"
+ " additional_compile_targets list refers to a group, then\n"
" any dependencies of that group will be returned if they are out\n"
" of date, but the group itself does not need to be. If the\n"
" dependencies themselves are groups, the same filtering is\n"
" repeated. This filtering can be used to avoid rebuilding\n"
" dependencies of a group that are unaffected by the input files.\n"
- " The list may contain the string \"all\" to refer to a\n"
- " pseudo-group that contains every root target in the build graph.\n"
+ " The list may also contain the string \"all\" to refer to a\n"
+ " pseudo-group that contains every root target in the build\n"
+ " graph.\n"
"\n"
" This filtering behavior is also known as \"pruning\" the list\n"
" of compile targets.\n"
"\n"
- " - \"test_targets\": A list of the labels for targets that\n"
- " are needed to run the tests we wish to run. Unlike\n"
- " \"compile_targets\", this list may not contain the string \"all\",\n"
- " because having a test be dependent on everything in the build\n"
- " would be silly.\n"
- "\n"
" output_path is a path indicating where the results of the command\n"
" are to be written. The results will be a file containing a JSON\n"
" object with one or more of following fields:\n"
« no previous file with comments | « tools/gn/analyzer_unittest.cc ('k') | tools/gn/docs/reference.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698