DBC: Double converstion instructions

DBC: Double converstion instructions

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/bc1dc06687c5b7ee74ad2d919f41b85e0717113c

[zra, 2016-09-14 22:52:52]

zra@google.com changed reviewers:
+ fschneider@google.com

[zra, 2016-09-14 22:52:53]

This fixes bailouts for Flutter, but doesn't have a measurable performance
improvement. The same functions probably also contain other bailouts for
typed-data etc..

[Florian Schneider, 2016-09-15 02:02:26]

Lgtm.

You will get the full performance benefit only if you also add the corresponding
Float32 operations that use double/float conversion.

https://codereview.chromium.org/2341683003/diff/40001/runtime/vm/intermediate...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2341683003/diff/40001/runtime/vm/intermediate...
runtime/vm/intermediate_language_dbc.cc:1616: EMIT_NATIVE_CODE(DoubleToFloat, 1,
Location::RequiresRegister()) {
This won't be tested until you have support for optimized
LoadIndexed/StoreIndexed for Float32List. It would make sense to add these in
the same CL.

https://codereview.chromium.org/2341683003/diff/40001/runtime/vm/intermediate...
runtime/vm/intermediate_language_dbc.cc:1623: EMIT_NATIVE_CODE(FloatToDouble, 1,
Location::RequiresRegister()) {
Same comment as above.

[zra, 2016-09-15 15:09:31]

https://codereview.chromium.org/2341683003/diff/40001/runtime/vm/intermediate...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2341683003/diff/40001/runtime/vm/intermediate...
runtime/vm/intermediate_language_dbc.cc:1616: EMIT_NATIVE_CODE(DoubleToFloat, 1,
Location::RequiresRegister()) {
On 2016/09/15 02:02:26, Florian Schneider wrote:
> This won't be tested until you have support for optimized
> LoadIndexed/StoreIndexed for Float32List. It would make sense to add these in
> the same CL. 

Done.

https://codereview.chromium.org/2341683003/diff/40001/runtime/vm/intermediate...
runtime/vm/intermediate_language_dbc.cc:1623: EMIT_NATIVE_CODE(FloatToDouble, 1,
Location::RequiresRegister()) {
On 2016/09/15 02:02:26, Florian Schneider wrote:
> Same comment as above.

Done.

[Florian Schneider, 2016-09-15 16:05:45]

Lgtm

https://codereview.chromium.org/2341683003/diff/60001/runtime/vm/simulator_db...
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2341683003/diff/60001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:2012: const int64_t value64 = value;
uint64_t?

https://codereview.chromium.org/2341683003/diff/60001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:2025: const int64_t value64 = value;  // sign extend
to clear high bits.
uint64_t? The upper bits of the value that holds the float are ignored, so both
(sign-extend or zero-extend) should work, but you use uint64_t in StoreIndexed
as well.

[zra, 2016-09-15 16:18:21]

https://codereview.chromium.org/2341683003/diff/60001/runtime/vm/simulator_db...
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2341683003/diff/60001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:2012: const int64_t value64 = value;
On 2016/09/15 16:05:45, Florian Schneider wrote:
> uint64_t?

Done.

https://codereview.chromium.org/2341683003/diff/60001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:2025: const int64_t value64 = value;  // sign extend
to clear high bits.
On 2016/09/15 16:05:45, Florian Schneider wrote:
> uint64_t? The upper bits of the value that holds the float are ignored, so
both
> (sign-extend or zero-extend) should work, but you use uint64_t in StoreIndexed
> as well.

Done.

[zra, 2016-09-15 16:18:35]

Description was changed from

==========
DBC: Double converstion instructions
==========

to

==========
DBC: Double converstion instructions

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bc1dc06687c5b7ee74ad2d919f41b85e0717113c
==========

[zra, 2016-09-15 16:18:36]

Committed patchset #6 (id:100001) manually as
bc1dc06687c5b7ee74ad2d919f41b85e0717113c (presubmit successful).