[wasm] Implement GrowMemory in the wasm interpreter

[wasm] Implement GrowMemory in the wasm interpreter

R=titzer@chromium.org

Committed: https://crrev.com/d7ee8124e8d1d9d742039d59a001d055eaaf8066
Cr-Commit-Position: refs/heads/master@{#39406}

[ahaas, 2016-09-14 07:28:07]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 07:28:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-09-14 07:28:27]

ahaas@chromium.org changed reviewers:
+ gdeepti@chromium.org

[commit-bot: I haz the power, 2016-09-14 07:54:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 07:54:10]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-09-14 07:57:08]

lgtm other than comment

https://codereview.chromium.org/2341653002/diff/1/src/wasm/wasm-interpreter.cc
File src/wasm/wasm-interpreter.cc (right):

https://codereview.chromium.org/2341653002/diff/1/src/wasm/wasm-interpreter.c...
src/wasm/wasm-interpreter.cc:679: new_mem_start =
static_cast<byte*>(realloc(instance->mem_start, new_size));
Can you put a TODO here to call back into something in wasm-module.cc for the
actual allocation of memory? For example, it might be in the future that the
memory actually really is a JS array buffer and the instance needs to be fixed
(e.g. when debugging).

[ahaas, 2016-09-14 08:47:18]

https://codereview.chromium.org/2341653002/diff/1/src/wasm/wasm-interpreter.cc
File src/wasm/wasm-interpreter.cc (right):

https://codereview.chromium.org/2341653002/diff/1/src/wasm/wasm-interpreter.c...
src/wasm/wasm-interpreter.cc:679: new_mem_start =
static_cast<byte*>(realloc(instance->mem_start, new_size));
On 2016/09/14 at 07:57:08, titzer wrote:
> Can you put a TODO here to call back into something in wasm-module.cc for the
actual allocation of memory? For example, it might be in the future that the
memory actually really is a JS array buffer and the instance needs to be fixed
(e.g. when debugging).

Done.

[ahaas, 2016-09-14 08:47:21]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-09-14 08:47:21]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2341653002/#ps20001
(title: "Add comment")

[commit-bot: I haz the power, 2016-09-14 08:47:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 09:19:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-14 09:19:54]

Description was changed from

==========
[wasm] Implement GrowMemory in the wasm interpreter

R=titzer@chromium.org
==========

to

==========
[wasm] Implement GrowMemory in the wasm interpreter

R=titzer@chromium.org

Committed: https://crrev.com/d7ee8124e8d1d9d742039d59a001d055eaaf8066
Cr-Commit-Position: refs/heads/master@{#39406}
==========

[commit-bot: I haz the power, 2016-09-14 09:19:55]

Patchset 2 (id:??) landed as
https://crrev.com/d7ee8124e8d1d9d742039d59a001d055eaaf8066
Cr-Commit-Position: refs/heads/master@{#39406}