Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2341673002:
[wasm] Allocate memory for the wasm interpreter in the fuzzer. (Closed)
Description[wasm] Allocate memory for the wasm interpreter in the fuzzer.
R=titzer@chromium.org
BUG=chromium:646258
Committed: https://crrev.com/6d89f8a7fc56e41b08df1c4b52f539fb8b27b24e
Cr-Commit-Position: refs/heads/master@{#39419}
Patch Set 1 #Patch Set 2 : Apparently unique_ptr is able to manage the result of calloc #Patch Set 3 : Do not use an unique_ptr #Patch Set 4 : Rebase #Patch Set 5 : signed/unsigned comparison #Patch Set 6 : Delete stale code. #Messages
Total messages: 35 (27 generated)
The CQ bit was checked by ahaas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by ahaas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)
The CQ bit was checked by ahaas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/14 at 08:44:22, ahaas wrote: > PTAL. I also refactored the code slightly so that a WasmInstance is only allocated if the WasmModule decoding verifies.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24034)
The CQ bit was checked by ahaas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
lgtm lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/14268)
The CQ bit was checked by ahaas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by ahaas@chromium.org
The CQ bit was checked by ahaas@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org Link to the patchset: https://codereview.chromium.org/2341673002/#ps70001 (title: "signed/unsigned comparison")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by ahaas@chromium.org
The CQ bit was checked by ahaas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ahaas@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org Link to the patchset: https://codereview.chromium.org/2341673002/#ps90001 (title: "Delete stale code.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #6 (id:90001)
Message was sent while issue was closed.
Description was changed from ========== [wasm] Allocate memory for the wasm interpreter in the fuzzer. R=titzer@chromium.org BUG=chromium:646258 ========== to ========== [wasm] Allocate memory for the wasm interpreter in the fuzzer. R=titzer@chromium.org BUG=chromium:646258 Committed: https://crrev.com/6d89f8a7fc56e41b08df1c4b52f539fb8b27b24e Cr-Commit-Position: refs/heads/master@{#39419} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/6d89f8a7fc56e41b08df1c4b52f539fb8b27b24e Cr-Commit-Position: refs/heads/master@{#39419} |
