Enhance chrome.app.window API for shelf integration with pinning support (cont.)

ash/common/shelf/shelf_delegate.h

Index: ash/common/shelf/shelf_delegate.h
diff --git a/ash/common/shelf/shelf_delegate.h b/ash/common/shelf/shelf_delegate.h
index dbfe62741567c6e6cda1e6ba5021ac62c53a2ea5..363535578d825e9e4fa0ef28952498337d848830 100644
--- a/ash/common/shelf/shelf_delegate.h
+++ b/ash/common/shelf/shelf_delegate.h
@@ -40,6 +40,9 @@ class ASH_EXPORT ShelfDelegate {
   // ShelfID can be successfully mapped to an app id.
   virtual const std::string& GetAppIDForShelfID(ShelfID id) = 0;
 
+  // Get the launch ID for a given shelf ID.
+  virtual const std::string& GetLaunchIDForShelfID(ShelfID id) = 0;

[James Cook, 2016/10/21 15:11:03]

I don't see any calls to this inside //ash. If it is only used in //chrome, it
doesn't need to be a method on the ash delegate -- the code in chrome should
look it up in that layer.

(//ash is conceptually "below" //chrome in the dependency hierarchy. These
delegates exist so that ash can occasionally call "up" to get a piece of
information it needs.)

[Andra Paraschiv, 2016/10/24 08:26:16]

Thank you, James, for the explanation, I moved this in the //chrome layer and
removed unnecessary changes from //ash.

+
   // Pins an app with |app_id| to shelf. A running instance will get pinned.
   // In case there is no running instance a new shelf item is created and
   // pinned.