Enhance chrome.app.window API for shelf integration with pinning support (cont.)

ash/common/shelf/shelf_delegate.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_SHELF_SHELF_DELEGATE_H_
 #define ASH_COMMON_SHELF_SHELF_DELEGATE_H_
 
 #include <string>
 
 #include "ash/ash_export.h"
@@ skipping 22 matching lines @@
       const std::string& launch_id) = 0;
 
   // Checks whether a mapping exists from the ShelfID |id| to an app id.
   virtual bool HasShelfIDToAppIDMapping(ShelfID id) const = 0;
 
   // Get the application ID for a given shelf ID.
   // |HasShelfIDToAppIDMapping(ShelfID)| should be called first to ensure the
   // ShelfID can be successfully mapped to an app id.
   virtual const std::string& GetAppIDForShelfID(ShelfID id) = 0;
 
+  // Get the launch ID for a given shelf ID.
+  virtual const std::string& GetLaunchIDForShelfID(ShelfID id) = 0;

[James Cook, 2016/10/21 15:11:03]

I don't see any calls to this inside //ash. If it is only used in //chrome, it
doesn't need to be a method on the ash delegate -- the code in chrome should
look it up in that layer.

(//ash is conceptually "below" //chrome in the dependency hierarchy. These
delegates exist so that ash can occasionally call "up" to get a piece of
information it needs.)

[Andra Paraschiv, 2016/10/24 08:26:16]

Thank you, James, for the explanation, I moved this in the //chrome layer and
removed unnecessary changes from //ash.

+
   // Pins an app with |app_id| to shelf. A running instance will get pinned.
   // In case there is no running instance a new shelf item is created and
   // pinned.
   virtual void PinAppWithID(const std::string& app_id) = 0;
 
   // Check if the app with |app_id_| is pinned to the shelf.
   virtual bool IsAppPinned(const std::string& app_id) = 0;
 
   // Unpins app item with |app_id|.
   virtual void UnpinAppWithID(const std::string& app_id) = 0;
 };
 
 }  // namespace ash
 
 #endif  // ASH_COMMON_SHELF_SHELF_DELEGATE_H_