chrome/browser/ui/views/omnibox/omnibox_view_views.h - Issue 2341633006: MacViews/a11y: Allow accessibility clients to update the selected text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 2341633006: MacViews/a11y: Allow accessibility clients to update the selected text. (Closed)

Patch Set: Move accessibility notification for text selection being changed to SelectRange() instead. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.h

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.h b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

index 2f45573895bc57c1b8bd62c20f7a5c57fcd8ad73..33b0bb89a93cef167ab02f059161cfc9cfa479e3 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.h

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

@@ -129,6 +129,8 @@ class OmniboxViewViews

// using an accessibility API (typically automation software, screen readers

// don't normally use this). Sets the value and clears the selection.

void AccessibilitySetValue(const base::string16& new_value);

+ // Same as above, but replaces selected text/inserts new text at the cursor.

tapted 2016/09/27 07:16:30 nit: blank line before. "above" -> AccessibilitySe

Patti Lor 2016/10/20 04:19:34 Done.

+ void AccessibilityReplaceSelection(const base::string16& new_value);

// Updates |security_level_| based on the toolbar model's current value.

void UpdateSecurityLevel();