Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 2341633006: MacViews/a11y: Allow accessibility clients to update the selected text. (Closed)
Patch Set: Move accessibility notification for text selection being changed to SelectRange() instead. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
6 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 // necessary. 122 // necessary.
123 void OnPaste(); 123 void OnPaste();
124 124
125 // Handle keyword hint tab-to-search and tabbing through dropdown results. 125 // Handle keyword hint tab-to-search and tabbing through dropdown results.
126 bool HandleEarlyTabActions(const ui::KeyEvent& event); 126 bool HandleEarlyTabActions(const ui::KeyEvent& event);
127 127
128 // Handles a request to change the value of this text field from software 128 // Handles a request to change the value of this text field from software
129 // using an accessibility API (typically automation software, screen readers 129 // using an accessibility API (typically automation software, screen readers
130 // don't normally use this). Sets the value and clears the selection. 130 // don't normally use this). Sets the value and clears the selection.
131 void AccessibilitySetValue(const base::string16& new_value); 131 void AccessibilitySetValue(const base::string16& new_value);
132 // Same as above, but replaces selected text/inserts new text at the cursor.
tapted 2016/09/27 07:16:30 nit: blank line before. "above" -> AccessibilitySe
Patti Lor 2016/10/20 04:19:34 Done.
133 void AccessibilityReplaceSelection(const base::string16& new_value);
132 134
133 // Updates |security_level_| based on the toolbar model's current value. 135 // Updates |security_level_| based on the toolbar model's current value.
134 void UpdateSecurityLevel(); 136 void UpdateSecurityLevel();
135 137
136 // OmniboxView: 138 // OmniboxView:
137 void SetWindowTextAndCaretPos(const base::string16& text, 139 void SetWindowTextAndCaretPos(const base::string16& text,
138 size_t caret_pos, 140 size_t caret_pos,
139 bool update_popup, 141 bool update_popup,
140 bool notify_text_changed) override; 142 bool notify_text_changed) override;
141 bool IsSelectAll() const override; 143 bool IsSelectAll() const override;
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 // painted. Used to measure omnibox responsiveness with a histogram. 254 // painted. Used to measure omnibox responsiveness with a histogram.
253 base::TimeTicks insert_char_time_; 255 base::TimeTicks insert_char_time_;
254 256
255 // Used to bind callback functions to this object. 257 // Used to bind callback functions to this object.
256 base::WeakPtrFactory<OmniboxViewViews> weak_ptr_factory_; 258 base::WeakPtrFactory<OmniboxViewViews> weak_ptr_factory_;
257 259
258 DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews); 260 DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews);
259 }; 261 };
260 262
261 #endif // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 263 #endif // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698