MacViews/a11y: Allow accessibility clients to update the selected text.

chrome/browser/ui/views/omnibox/omnibox_view_views.h

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.h
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.h b/chrome/browser/ui/views/omnibox/omnibox_view_views.h
index 2f45573895bc57c1b8bd62c20f7a5c57fcd8ad73..486b53087d8064f68c34f116fe0e6bf746a2c60e 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.h
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.h
@@ -127,8 +127,10 @@ class OmniboxViewViews
 
   // Handles a request to change the value of this text field from software
   // using an accessibility API (typically automation software, screen readers
-  // don't normally use this). Sets the value and clears the selection.
-  void AccessibilitySetValue(const base::string16& new_value);
+  // don't normally use this). If |clear_first| is true, clears the existing
+  // value first and sets it to |new_value|. If false, deletes whatever's
+  // selected and replaces it with |new_value|. Then clears the text selection.

[dmazzoni, 2016/10/26 04:26:02]

Doesn't it leave the cursor at the end of |new_value|?

Suppose the omnibox contains "bread turkey bread" and "turkey" is selected, and
|new_value| is "tofu".

If |clear_first| is true, I'd expect the omnibox to contain "tofu" with the
cursor at the end.

If |clear_first| is false, I'd expect the omnibox to contain "bread tofu bread"
with the cursor at the end of "tofu", not at the end of the whole sandwich.

[Patti Lor, 2016/10/27 00:38:48]

That's true - replaced "Then clears the text selection" with "The cursor is then
placed at the end of |new_value|.". (Both here and in textfield.h).

+  void AccessibilitySetValue(const base::string16& new_value, bool clear_first);
 
   // Updates |security_level_| based on the toolbar model's current value.
   void UpdateSecurityLevel();