MacViews/a11y: Allow accessibility clients to update the selected text.

chrome/browser/ui/views/omnibox/omnibox_view_views.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
 
 #include <stddef.h>
 
 #include <memory>
@@ skipping 109 matching lines @@
   // as is. We want to strip whitespace and other things (see GetClipboardText()
   // for details). The function invokes OnBefore/AfterPossibleChange() as
   // necessary.
   void OnPaste();
 
   // Handle keyword hint tab-to-search and tabbing through dropdown results.
   bool HandleEarlyTabActions(const ui::KeyEvent& event);
 
   // Handles a request to change the value of this text field from software
   // using an accessibility API (typically automation software, screen readers
-  // don't normally use this). Sets the value and clears the selection.
-  void AccessibilitySetValue(const base::string16& new_value);
+  // don't normally use this). If |clear_first| is true, clears the existing
+  // value first and sets it to |new_value|. If false, deletes whatever's
+  // selected and replaces it with |new_value|. Then clears the text selection.

[dmazzoni, 2016/10/26 04:26:02]

Doesn't it leave the cursor at the end of |new_value|?

Suppose the omnibox contains "bread turkey bread" and "turkey" is selected, and
|new_value| is "tofu".

If |clear_first| is true, I'd expect the omnibox to contain "tofu" with the
cursor at the end.

If |clear_first| is false, I'd expect the omnibox to contain "bread tofu bread"
with the cursor at the end of "tofu", not at the end of the whole sandwich.

[Patti Lor, 2016/10/27 00:38:48]

That's true - replaced "Then clears the text selection" with "The cursor is then
placed at the end of |new_value|.". (Both here and in textfield.h).

+  void AccessibilitySetValue(const base::string16& new_value, bool clear_first);
 
   // Updates |security_level_| based on the toolbar model's current value.
   void UpdateSecurityLevel();
 
   // OmniboxView:
   void SetWindowTextAndCaretPos(const base::string16& text,
                                 size_t caret_pos,
                                 bool update_popup,
                                 bool notify_text_changed) override;
   bool IsSelectAll() const override;
@@ skipping 110 matching lines @@
   // painted. Used to measure omnibox responsiveness with a histogram.
   base::TimeTicks insert_char_time_;
 
   // Used to bind callback functions to this object.
   base::WeakPtrFactory<OmniboxViewViews> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_