MacViews/a11y: Allow accessibility clients to update the selected text.

ui/accessibility/ax_view_state.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_ACCESSIBILITY_AX_VIEW_STATE_H_
 #define UI_ACCESSIBILITY_AX_VIEW_STATE_H_
 
 #include <stdint.h>
 
 #include "base/callback.h"
@@ skipping 57 matching lines @@
   // The selected item's index and the count of the number of items.
   // Only applies to views with multiple choices like a listbox; both
   // index and count should be -1 otherwise.
   int index;
   int count;
 
   // An optional callback that can be used by accessibility clients to
   // set the string value of this view. This only applies to roles where
   // setting the value makes sense, like a text box. Not often used by
   // screen readers, but often used by automation software to script
-  // things like logging into portals or filling forms.
+  // things like logging into portals or filling forms. Set the second argument
+  // to insert at the cursor or replace the currently selected text.
   //
   // This callback is only valid for the lifetime of the view, and should
   // be a safe no-op if the view is deleted. Typically, accessible views
   // should use a WeakPtr when binding the callback.
-  base::Callback<void(const base::string16&)> set_value_callback;
+  base::Callback<void(const base::string16&, bool)> set_value_callback;

[dmazzoni, 2016/10/25 17:21:49]

Maybe the same here, the bool could be replace all.

Just an FYI, I just recently added ui/accessibility/ax_action_data.h
as a more generic way to encapsulate different actions that could
be taken on accessible objects. We should probably replace this
with a callback that takes an AXActionData as an argument and
handles that action. That will allow us to share a lot more code
between platforms.

OK to leave things as they are for this change, but let's switch
to that before we add another callback if we find ourselves tempted
to add another one.

[Patti Lor, 2016/10/26 00:57:15]

Ah, thanks for the FYI - will definitely be needing more callbacks in future CLs
I think, so this is useful.

 
  private:
   uint32_t state_;
 };
 
 }  // namespace ui
 
 #endif  // UI_ACCESSIBILITY_AX_VIEW_STATE_H_