Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3751)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.js

Issue 2341593002: [MD settings] ripple on mouse down in side nav (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_menu/settings_menu.js
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index 29d51ad9a343ed87858f227cd18ef48af1765f1c..a5ea67415c72771a59d19f10e99d435c55b4fcf3 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -70,20 +70,6 @@ Polymer({
* @param {!Event} event
* @private
*/
- ripple_: function(event) {
- var ripple = document.createElement('paper-ripple');
- ripple.addEventListener('transitionend', function() {
- ripple.remove();
- });
- event.currentTarget.appendChild(ripple);
- ripple.downAction();
- ripple.upAction();
- },
-
- /**
- * @param {!Event} event
- * @private
- */
openPage_: function(event) {
var route = settings.getRouteForPath(event.currentTarget.dataset.path);
assert(route, 'settings-menu has an an entry with an invalid path');
« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698