Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8032)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 2341593002: [MD settings] ripple on mouse down in side nav (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_menu/settings_menu.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_menu/settings_menu.html
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html
index 429bbb2b23206eaf2b4ececaf3ffc9f18fd56a49..abd0493712b38839c8c0963cc66f7ddcab24de89 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.html
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html
@@ -77,7 +77,7 @@
}
.page-menu div {
- -webkit-margin-start: 24px;
+ -webkit-padding-start: 24px;
align-items: center;
display: flex;
font-size: 13px;
@@ -138,9 +138,10 @@
<paper-submenu class="page-menu" id="advancedPage" actionable
opened="{{advancedOpened_}}"
hidden="[[!pageVisibility.advancedSettings]]">
- <div class="menu-trigger" on-tap="ripple_">
+ <div class="menu-trigger">
<span>$i18n{advancedPageTitle}</span>
<iron-icon icon="[[arrowState_(advancedOpened_)]]"></iron-icon>
+ <paper-ripple></paper-ripple>
</div>
<paper-menu attr-for-selected="data-path" class="menu-content"
id="advancedMenu" selected="[[currentRoute.path]]">
« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_menu/settings_menu.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698