Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2341593002:
[MD settings] ripple on mouse down in side nav (Closed)
|
Created:
4 years, 3 months ago by dschuyler Modified:
4 years, 3 months ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] ripple on mouse down in side nav
This CL changes the ripple to trigger on mouse down rather than mouse
up. This better matches other uses of paper-ripple.
BUG=645190
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/b9adedb441e090b88388e0f61333163967bc0264
Cr-Commit-Position: refs/heads/master@{#419331}
Patch Set 1 : #
Total comments: 2
Patch Set 2 : #
Messages
Total messages: 27 (18 generated)
Description was changed from ========== [MD settings] ripple on mouse down in side nav This CL changes the ripple to trigger on mouse down rather than mouse up. This better matches other uses of paper-ripple. BUG=645190 ========== to ========== [MD settings] ripple on mouse down in side nav This CL changes the ripple to trigger on mouse down rather than mouse up. This better matches other uses of paper-ripple. BUG=645190 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
dschuyler@chromium.org changed reviewers: + tommycli@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
https://codereview.chromium.org/2341593002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/settings_menu/settings_menu.html (right): https://codereview.chromium.org/2341593002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/settings_menu/settings_menu.html:141: <div class="menu-trigger" on-mousedown="ripple_"> does this work with touchstart or keydown?
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The reason we were using the ripple_ function to create and destroy ripple was that every menu item was going to have a ripple. Now that only Advanced has a ripple, I've switched to simply using a paper-ripple. PTAL. https://codereview.chromium.org/2341593002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/settings_menu/settings_menu.html (right): https://codereview.chromium.org/2341593002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/settings_menu/settings_menu.html:141: <div class="menu-trigger" on-mousedown="ripple_"> On 2016/09/15 01:11:09, Dan Beam wrote: > does this work with touchstart or keydown? How about I just use a paper-ripple :)
The reason we were using the ripple_ function to create and destroy ripple was that every menu item was going to have a ripple. Now that only Advanced has a ripple, I've switched to simply using a paper-ripple. PTAL. https://codereview.chromium.org/2341593002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/settings_menu/settings_menu.html (right): https://codereview.chromium.org/2341593002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/settings_menu/settings_menu.html:141: <div class="menu-trigger" on-mousedown="ripple_"> On 2016/09/15 01:11:09, Dan Beam wrote: > does this work with touchstart or keydown? How about I just use a paper-ripple :)
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] ripple on mouse down in side nav This CL changes the ripple to trigger on mouse down rather than mouse up. This better matches other uses of paper-ripple. BUG=645190 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] ripple on mouse down in side nav This CL changes the ripple to trigger on mouse down rather than mouse up. This better matches other uses of paper-ripple. BUG=645190 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b9adedb441e090b88388e0f61333163967bc0264 Cr-Commit-Position: refs/heads/master@{#419331} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b9adedb441e090b88388e0f61333163967bc0264 Cr-Commit-Position: refs/heads/master@{#419331} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
