Handle generic factory constructors in kernel_impact

Handle generic factory constructors in kernel_impact

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/e24939f8d6274473fca8bbd81a13d3e7e81d11a7

[Johnni Winther, 2016-09-16 11:01:26]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-09-16 16:58:30]

lgtm

nice!

https://codereview.chromium.org/2341263002/diff/1/pkg/compiler/lib/src/ssa/ke...
File pkg/compiler/lib/src/ssa/kernel_impact.dart (right):

https://codereview.chromium.org/2341263002/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_impact.dart:202: // rather follow the type
arguments directly.
What do you mean by "follow the type arguments"? I get that we don't want to
mark the types as instantiated, but don't follow what the proposed alternative
is

[Johnni Winther, 2016-09-19 08:10:18]

https://codereview.chromium.org/2341263002/diff/1/pkg/compiler/lib/src/ssa/ke...
File pkg/compiler/lib/src/ssa/kernel_impact.dart (right):

https://codereview.chromium.org/2341263002/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_impact.dart:202: // rather follow the type
arguments directly.
On 2016/09/16 16:58:30, Harry Terkelsen wrote:
> What do you mean by "follow the type arguments"? I get that we don't want to
> mark the types as instantiated, but don't follow what the proposed alternative
> is

Consider this:

abstract class A<T> {
  factory A.regular() => new B<T>();
  factory A.redirect() = B<T>;
}

class B<T> implements A<T> {}

main() {
  print(new A<int>.regular() is B<int>);
  print(new A<String>.redirect() is B<String>);
}

To track that B is actually instantiated as B<int> and B<String> we need to
follow the type arguments passed to A.regular and A.redirect to B. Currently, we
only do this soundly if we register A<int> and A<String> as instantiated. We
should instead register that A.T is instantiated as int and String.

[Johnni Winther, 2016-09-19 09:36:03]

Description was changed from

==========
Handle generic factory constructors in kernel_impact
==========

to

==========
Handle generic factory constructors in kernel_impact

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e24939f8d6274473fca8bbd81a13d3e7e81d11a7
==========

[Johnni Winther, 2016-09-19 09:36:04]

Committed patchset #2 (id:20001) manually as
e24939f8d6274473fca8bbd81a13d3e7e81d11a7 (presubmit successful).