Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: pkg/compiler/lib/src/resolution/type_resolver.dart

Issue 2341263002: Handle generic factory constructors in kernel_impact (Closed)
Patch Set: Updated cf. comment. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/type_resolver.dart
diff --git a/pkg/compiler/lib/src/resolution/type_resolver.dart b/pkg/compiler/lib/src/resolution/type_resolver.dart
index c1fb6cc72ced5caf80a69ea8fae17077d8e3cc0a..274911d48a01e731788cd3db32157b573c8e2de8 100644
--- a/pkg/compiler/lib/src/resolution/type_resolver.dart
+++ b/pkg/compiler/lib/src/resolution/type_resolver.dart
@@ -176,7 +176,8 @@ class TypeResolver {
} else {
type = new InterfaceType(
cls.declaration, arguments.toList(growable: false));
- addTypeVariableBoundsCheck = true;
+ addTypeVariableBoundsCheck =
+ arguments.any((DartType type) => !type.isDynamic);
}
}
} else if (element.isTypedef) {
@@ -195,7 +196,8 @@ class TypeResolver {
type = typdef.rawType;
} else {
type = new TypedefType(typdef, arguments.toList(growable: false));
- addTypeVariableBoundsCheck = true;
+ addTypeVariableBoundsCheck =
+ arguments.any((DartType type) => !type.isDynamic);
}
}
} else if (element.isTypeVariable) {
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698